joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Skip does not work since it does not apply to the stop goal #55 #57

Closed indriesergiu closed 8 years ago

indriesergiu commented 8 years ago

It seems that the issue was caused by the fact that StopMojo was using the old way of defining the mojo goal using javadoc. After I changed to annotations it just worked. I also wanted to write some tests to check this and I finally got the Maven Plugin Testing Harness to work (very nasty, doc is really outdated), that is why some of the Maven artifact versions were bumped up (a lot of conflicts and missing classes). The only problem is that the tests seem to pass even with the old StopMojo. I would suggest to keep the test setup for the future.

Thanks