search

joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Master #59

Closed bkmurchison closed 8 years ago

bkmurchison commented 8 years ago

Added plugin param "scriptCharsetEncoding" to allow the script files to be read in using encoding other than that of the underlying platform. Relying on the underlying platform encoding has caused issues running the scripts when the scripts contain UTF-8 characters in the JSON. Updated documentation for the new param as well.

joelittlejohn commented 8 years ago

Thanks @bkmurchison! This looks great. I've added some minor review comments. If you could address these then rebase into one commit I will merge and create a new release.

bkmurchison commented 8 years ago

Thanks. Will address your comments.

bkmurchison commented 8 years ago

@joelittlejohn - comments have been addressed and rebase performed. Let me know if anything has been missed.