search

joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Support the configuration of the storageEngine and use latest de.flap… #60

Closed codescale closed 8 years ago

codescale commented 8 years ago

With MongoDB 3.2.x the default storageEngine became wiredTiger. In some cases it's not requested to let the "Embeded"-MongoDB use this storageEngine but test e.g. with the In-Memory Database. This change supports the configuration of the storageEngine.

joelittlejohn commented 8 years ago

Great addition, thanks. Could you add the new storageEngine option to the README.md example?

joelittlejohn commented 8 years ago

When you're done I'll release a new version.

joelittlejohn commented 8 years ago

One thing I think we need to change here before we release:

You've chosen wiredTiger as the default, but mongod's default is mmapv1. I expect this will be confusing for some users, we should match the existing tools IMO and use mmapv1 as the default.

codescale commented 8 years ago

I'll add the storageEngine option to the README.md, no worries.

The default is up to you to decide. Actually for 3.2 the default is wiredTiger. Within 3.0 the default was mmapv1. See https://docs.mongodb.org/manual/core/storage-engines/

joelittlejohn commented 8 years ago

Thanks, I've update the docs and changed the default.

I guess the best option would be to have the default match the default for whatever version of Mongo you are using, so the default is 'unspecified'. I'll update this for the next version.

0.3.4 is released already with this feature by the way. On 24 Jan 2016 16:00, "codescale" notifications@github.com wrote:

I'll add the storageEngine option to the README.md, no worries.

The default is up to you to decide. Actually for 3.2 the default is wiredTiger. Within 3.0 the default was mmapv1. See https://docs.mongodb.org/manual/core/storage-engines/

— Reply to this email directly or view it on GitHub https://github.com/joelittlejohn/embedmongo-maven-plugin/pull/60#issuecomment-174311694 .

codescale commented 8 years ago

Ah well perfect. In this case you can ignore the other pull request :) (https://github.com/joelittlejohn/embedmongo-maven-plugin/pull/61)

Thanks! :+1: