joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Added config support for flapdoodle features #84

Closed mgaceanu closed 5 years ago

mgaceanu commented 5 years ago

Specify in the config the flapdoodle features to be enabled.

codescale commented 5 years ago

Well done @mgaceanu . Thanks for the PR!

joelittlejohn commented 5 years ago

I'm happy to release 0.4.2 now to get this out.

mgaceanu commented 5 years ago

@joelittlejohn it seems 0.4.2 is not yet released. Did you decided to delay it?

rkaltreider commented 5 years ago

I'm happy to release 0.4.2 now to get this out.

when is thins coming out? looking forward to it!

joelittlejohn commented 5 years ago

Sorry, I haven't had time to look at this yet. I'm travelling right now but back home at the weekend and I'll release.

rkaltreider commented 5 years ago

Thank you sir, greatly looking forward to it.

From: Joe Littlejohn notifications@github.com Sent: Thursday, August 22, 2019 10:26 AM To: joelittlejohn/embedmongo-maven-plugin embedmongo-maven-plugin@noreply.github.com Cc: Ryan Kaltreider ryan@vivanda.com; Comment comment@noreply.github.com Subject: Re: [joelittlejohn/embedmongo-maven-plugin] Added config support for flapdoodle features (#84)

Sorry, I haven't had time to look at this yet. I'm travelling right now but back home at the weekend and I'll release.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/joelittlejohn/embedmongo-maven-plugin/pull/84?email_source=notifications&email_token=ABJ4FNPJKW5ZAXR5JS5AMDDQF2OWJA5CNFSM4IIPVKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD45IOQA#issuecomment-523929408, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABJ4FNOC6X4RJA57CSHJDALQF2OWJANCNFSM4IIPVKJA.

rkaltreider commented 5 years ago

Any luck with the release?

From: Joe Littlejohn notifications@github.com Sent: Thursday, August 22, 2019 10:26 AM To: joelittlejohn/embedmongo-maven-plugin embedmongo-maven-plugin@noreply.github.com Cc: Ryan Kaltreider ryan@vivanda.com; Comment comment@noreply.github.com Subject: Re: [joelittlejohn/embedmongo-maven-plugin] Added config support for flapdoodle features (#84)

Sorry, I haven't had time to look at this yet. I'm travelling right now but back home at the weekend and I'll release.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/joelittlejohn/embedmongo-maven-plugin/pull/84?email_source=notifications&email_token=ABJ4FNPJKW5ZAXR5JS5AMDDQF2OWJA5CNFSM4IIPVKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD45IOQA#issuecomment-523929408, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABJ4FNOC6X4RJA57CSHJDALQF2OWJANCNFSM4IIPVKJA.

joelittlejohn commented 5 years ago

Thanks for the reminder. I've just released 0.4.2. It should usable right now I think, and visible in Maven central search in a few hours.

rkaltreider commented 5 years ago

Thanks! You’re the man! The new features work great…I can finally embed mongo 4.0.12!!! Of course now they released 4.2.0 which only runs on windows server 2012 so the paths need updated again, but that’s will be handled in the other project….may just need to update dependency in the embedmongo plugin.

From: Joe Littlejohn notifications@github.com Sent: Tuesday, August 27, 2019 9:05 AM To: joelittlejohn/embedmongo-maven-plugin embedmongo-maven-plugin@noreply.github.com Cc: Ryan Kaltreider ryan@vivanda.com; Comment comment@noreply.github.com Subject: Re: [joelittlejohn/embedmongo-maven-plugin] Added config support for flapdoodle features (#84)

Thanks for the reminder. I've just released 0.4.2. It should usable right now I think, and visible in Maven central search in a few hours.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/joelittlejohn/embedmongo-maven-plugin/pull/84?email_source=notifications&email_token=ABJ4FNOJS3YGVQ5DNUJKWN3QGUQ6RA5CNFSM4IIPVKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HU76A#issuecomment-525291512, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABJ4FNKTR2PHRBHD5B6C7ETQGUQ6RANCNFSM4IIPVKJA.

joelittlejohn commented 5 years ago

Good stuff, thanks for the update! Whenever you need to bump the version of the flapdoodle library in this project, feel free to submit a PR and I'll try to get it merged and released more quickly :)

rkaltreider commented 5 years ago

Will do! Thanks again!

From: Joe Littlejohn notifications@github.com Sent: Thursday, August 29, 2019 11:08 AM To: joelittlejohn/embedmongo-maven-plugin embedmongo-maven-plugin@noreply.github.com Cc: Ryan Kaltreider ryan@vivanda.com; Comment comment@noreply.github.com Subject: Re: [joelittlejohn/embedmongo-maven-plugin] Added config support for flapdoodle features (#84)

Good stuff, thanks for the update! Whenever you need to bump the version of the flapdoodle library in this project, feel free to submit a PR and I'll try to get it merged and released more quickly :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/joelittlejohn/embedmongo-maven-plugin/pull/84?email_source=notifications&email_token=ABJ4FNPIMRRTGCAYFVUXA63QG7Q47A5CNFSM4IIPVKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5OZ3HA#issuecomment-526228892, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABJ4FNJMOZFXVKL33LLDLWDQG7Q47ANCNFSM4IIPVKJA.