joeljeske / karma-parallel

A Karma JS Framework to support sharding tests to run in parallel across multiple browsers
MIT License
82 stars 30 forks source link

karma-parallel do not return exit code 1 anymore on too low code coverage #35

Open petrce opened 5 years ago

petrce commented 5 years ago
petrce commented 5 years ago

workaround in poweshell:

$allOutput = & ng test --source-map --code-coverage 2>&1
echo $allOutput

if ($allOutput -cmatch 'ERROR')
{
    echo $matches
    Write-Error "(FAILED)"
}
joeljeske commented 5 years ago

What version of karma are you using?

nukithelegend commented 5 years ago

Having the same issue. Using karma 4.0.1 and karma-coverage-istanbul-reporter 2.0.5. Also using the same TypeScript and Angular 7

joeljeske commented 5 years ago

I have not yet tested with karma v4. Can you try downgrading to v3.x to see if that fixes it?

I’ll try to support v4, just seeing if that’s related.

ericcarino commented 4 years ago

Just to update, I'm seeing this issue still as well.

angular 8.2.4 angular/cli 8.3.2 karma 4.2.0 karma-parallel 0.3.1 karma-coverage-istanbul-reporter 2.0.6

joeljeske commented 4 years ago

Could you create a reproduction repo? I don’t use angular nor Istanbul in my normal processes.

ericcarino commented 4 years ago

@joeljeske here you go!

https://github.com/ericcarino/karma_parallel_bug