Closed joelle-o-world closed 1 year ago
Unit tests in Sample.test.cpp
, all to do with reading and writing samples
One strange message: filesystem error: in rename: No such file or directory https://github.com/joelle-o-world/naive-instruments/actions/runs/5929240872/job/16076518243?pr=90#step:12:514
AUDIO_TEST checksums not matching up. Some of which are a tiny discrepancy https://github.com/joelle-o-world/naive-instruments/actions/runs/5929240872/job/16076518243?pr=90#step:12:407
Question, is it ALL the AUDIO_TEST
s that are failing, or just some of them?
QUESTION: Is it because the PWD isn't correct? Nope because then we wouldn't be getting such similar checksums.
The failing tests for sample = the tests for sample which use the file system
They all log frame out of bounds: 0
then throw an unknown exception
That will be due to this bit
if ( frame < 0 || frame >= numberOfFrames() )
{
std::cerr << "frame out of bounds: " << frame << "\n";
throw 1; // TODO: Use proper exception
}
in Sample.h
The next step is to check that the the expected checksum txt files are being read correctly. To do this, add INFO logs to the custom assertion and manually check the output
Huge milestone! The tests actually run!
But some of them fail: