search

joelle-o-world / pattern-cutting

pattern-cutting
2 stars 1 forks source link

Add meshplot to dependencies #6

Open daara-s opened 1 year ago

daara-s commented 1 year ago

I've not tested it yet, but I used poetry add git+https://github.com/skoch9/meshplot.git to get the dependency added to poetry without conda

joelle-o-world commented 1 year ago

That's amazing, I didn't realise you could add git repositories as poetry dependencies!

I tested it and ran into problems. I had to run poetry add matplotlib and poetry add pythreejs because these dependencies are missing. However now I get the following error message:

poetry add git+https://github.com/skoch9/meshplot.git

I'll keep investigating. Might just be that meshplot isn't well maintained.

To reproduce, temporarily merge this branch onto embedding-meshes-in-jupyter-notebook and run sh ./run.sh

daara-s commented 1 year ago

yeah meshplot is pretty out of date. I forked it and updated its setup.py to also install the packages it depends on. Lmk if that works, I can clean up meshplot as needed.