null,null location tags upon photo upload

[GoogleCodeExporter]

What steps will reproduce the problem?
Not certain

What is the expected output? What do you see instead?
http://wiki.xkcd.com/wgh/index.php?title=2010-01-30_46_-122&oldid=203352
If the location is unknown, it should say something along the lines of
"unknown location" or "unlocated" or "position not available". 
I am not certain if maybe the image uploader does not receive the correct
position at all (which would be a different issue), but the message should
definitely be fixed.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by thomas.h...@gmail.com on 31 Jan 2010 at 12:45

[GoogleCodeExporter]

As it stands in-code, if the user specifies to send the coordinates along with a
picture, it first checks to see if the picture has coordinates embedded in it 
(by
default, if Android takes the picture and can get a GPS signal, it will), and 
if it
doesn't, it then tries the last known location from the map, and failing THAT, 
it
should ignore it entirely and treat it as if the user didn't check the box at 
all.

I just tested it with a few pictures and configurations, and I can't figure out 
how
that user got a "null, null" in the location.  If this can be reproduced, then 
I can
fix it, but as it stands, I don't know how that happened.

Original comment by captains...@gmail.com on 31 Jan 2010 at 9:15

• Changed state: New
• Added labels: Component-Wiki

[GoogleCodeExporter]

Oooooh... oops, my mistake, there IS a way in which that could happen.  Yes, if 
the
picture doesn't have location data, it just returns null to the String 
variables,
which, in turn, WILL report them as "null", as opposed to throwing an exception 
which
leads it to try to use the last-known location from the map.

However, in fixing issue 12 (r336 and r337), I serendipitously fixed this as 
well.  I
now have it formatting the data from the latitude and longitude of the picture. 
 If
DecimalFormat gets a null, that WILL throw an exception and keep the whole thing
moving along.

I've tested it on my test wiki (barring the problems in issue 8), and all seems 
to be
well.  If you could test it yourself, we could get this one closed.

Original comment by captains...@gmail.com on 31 Jan 2010 at 9:29

• Changed state: Accepted

[GoogleCodeExporter]

Yay! 
I will try to test it in the field, but I would trust you that we can close it 
for now. 

Original comment by thomas.h...@gmail.com on 31 Jan 2010 at 9:58

[GoogleCodeExporter]

Got it!  Closing it now, then...

Original comment by captains...@gmail.com on 31 Jan 2010 at 10:36

• Changed state: Fixed