joelmap / geohashdroid

Automatically exported from code.google.com/p/geohashdroid
0 stars 0 forks source link

Malformed OSM link for uploaded picture #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi,

Thanks for a very useful application! I like it much and use it quite 
regularly. On my latest trip I uploaded a picture to the Wiki and found a small 
bug.

1. Switch phone to Swedish (or German) locale and start the application.
2. Upload a picture to the Wiki containing location data.
3. Go to the Wiki and click the OSM link beneath the picture.

What is the expected output?  What happened instead?
Expected: OSM to open at the location where the picture was taken.
Actual: OSM opens in a different location (at latitude and longitude with out 
decimals) due to the fact that the latitude and longitude was formatted using 
containing comma (,) instead of dot (.)

What version of Geohash Droid are you using?  On what phone?
0.7.12 on Xperia MK16i

What version of Android is running on that phone, if you know?
2.3.4

Please provide any additional information below.
The DecimalFormatSymbols for the DecimalFormat object used (mLatLonFormat) 
could maybe be set to dot (.) before doing the formatting of the OSM link, 
otherwise it will be constructed using the default locale decimal symbol which 
for Swedish is (,) and will not get recognized by OSM.

Original issue reported on code.google.com by fasanen...@gmail.com on 9 Nov 2011 at 11:11

GoogleCodeExporter commented 9 years ago
Ah, oops.  Figured I missed a couple spots with that.

All right, I'll get that fixed as soon as I can.  Thanks for the report!

Original comment by captains...@gmail.com on 9 Nov 2011 at 11:52

GoogleCodeExporter commented 9 years ago
I've got the fix committed back to the repo.  I'll get it packaged into an apk, 
probably on Sunday (you caught me right when I had to travel for the weekend).  
I've tested it out a bit here and it seems to work, but I'll still probably put 
a pre-release version here for you to check over before I push it out to the 
Market.

Original comment by captains...@gmail.com on 11 Nov 2011 at 9:15

GoogleCodeExporter commented 9 years ago
Great! The link works. I don't want to be picky but I think that the link text 
should also be made US localized e.g. @62.3522,17.2823 is easier to read than 
@62,3522,17,2823 and period is used for presenting coordinates in decimal 
notation all over the world.

Original comment by fasanen...@gmail.com on 11 Nov 2011 at 6:21

GoogleCodeExporter commented 9 years ago
I was actually wondering about that a while ago, but I never actually got a 
definitive answer.  But, having done a bit of research online over the weekend, 
I can't seem to find any case where a set of geographic coordinates uses a 
comma as a decimal delimiter.  So, indeed, I've just committed a change that 
makes ALL coordinate readouts use periods instead.  Could you make sure I 
didn't miss any?  I think it's just in the spots I've already done, since most 
of it goes through UnitConverter.

Original comment by captains...@gmail.com on 14 Nov 2011 at 4:10

GoogleCodeExporter commented 9 years ago
I think that should keep it pretty much covered.  Coordinates look a bit more 
familiar in the whole application now.

Original comment by fasanen...@gmail.com on 14 Nov 2011 at 5:42

GoogleCodeExporter commented 9 years ago
Sweet.  I just pushed out 0.7.13 to the Marketplace, and all should be well.  
Thanks for the report!

Original comment by captains...@gmail.com on 16 Nov 2011 at 7:05