search

joelmap / geohashdroid

Automatically exported from code.google.com/p/geohashdroid
0 stars 0 forks source link

gallery photos not displayed #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. upload a picture to the wiki

What is the expected output? What do you see instead?
The code still expects the old {{Expedition}} template, which had a
visible, but empty gallery. In the new template, the gallery tags are
present, but commented out. We have to think how to handle this properly.

Original issue reported on code.google.com by thomas.h...@gmail.com on 31 Jan 2010 at 12:40

GoogleCodeExporter commented 9 years ago 
I think I've got it.  What happened is that the Photos section now includes a
commented-out example of the gallery tag.  That was being matched by the pattern
matcher, which in turn meant that the code was adding the photos, just in the
commented-out section.

As per r350, I added a couple more regexes that should first remove the 
commented
part if it exists (and only that commented part; it shouldn't remove any 
others),
then add the gallery in the right spot.  I've tested it on my private wiki, and 
it
seems to work properly.  If you can test it on your end, I'll get another 
release
pushed out.

Original comment by captains...@gmail.com on 19 Feb 2010 at 4:37

GoogleCodeExporter commented 9 years ago 
Oh right. I had actually just changed the template in the meantime to not hide 
the
tags. Will it work with both? I could change it back then.

In future, we might have to adapt once more if the usage of Template:Gallery 
becomes
more widespread (instead of the tags of the same name)

Original comment by thomas.h...@gmail.com on 19 Feb 2010 at 9:20

GoogleCodeExporter commented 9 years ago 
Aha.  Looking over what you changed on the wiki, that should still work, yeah.  
If
the new regex doesn't find the commented section, it'll just ignore it as it did
before (and if it doesn't find the gallery tag, it'll make a new one in the 
right
section).  But, the new regex should also make sure that if it gets changed 
back,
it'll still work anyway. :-)

Original comment by captains...@gmail.com on 19 Feb 2010 at 3:04

GoogleCodeExporter commented 9 years ago 
Actually, my mistake.  The comment matcher was now accidentally matching 
comments
from previous sections, wiping out whatever galleries were there to begin with.

As per r372, I removed the comment matcher entirely, as it's no longer needed 
with
the template change.  That seems to solve it.

Original comment by captains...@gmail.com on 29 Mar 2010 at 5:58

GoogleCodeExporter commented 9 years ago 
I'm marking this fixed, since after my most recent expedition, it looks like 
the 
pictures are being uploaded properly (at least in SVN).  Should be in 0.8.0, as 
soon 
as I get the GeohashService stuff finished.

Original comment by captains...@gmail.com on 6 Apr 2010 at 5:22