search

joelmap / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
0 stars 0 forks source link

Edit Saved Action causes Force Close #69

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create an Event/Action
2. Save that Rule
3. Go to the view rules page
3. View the Rule
4. Click the Action
5. Select Edit
6. Watch it Force Close Omnidroid

Original issue reported on code.google.com by case.and...@gmail.com on 20 May 2010 at 5:25

GoogleCodeExporter commented 9 years ago

Original comment by case.and...@gmail.com on 20 May 2010 at 5:26

GoogleCodeExporter commented 9 years ago 
Hi, can you elaborate on what kind of rule and action you used to reproduce 
this bug. I 
have tried doing different actions and I had no problem opening the edit window.

I used the revision 700 codebase and an AVD with API level 4.

Thanks!

Original comment by renc...@gmail.com on 25 May 2010 at 11:59

GoogleCodeExporter commented 9 years ago 
Issue 68 has been merged into this issue.

Original comment by case.and...@gmail.com on 26 May 2010 at 1:17

GoogleCodeExporter commented 9 years ago 
I think this has to do with adding multiple Actions to an event.
Create a rule for "Power connected" with the action "SMS Send".
Save it.
Open it to edit it, add another action "Dial Number", try to save.

The same thing happens if you create a rule with multiple actions.  If you can't
reproduce let me know and I'll specify the exact entries I put into input boxes.

Original comment by case.and...@gmail.com on 26 May 2010 at 1:20

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Hi Andrew,

I still have trouble reproducing the bug. After following your steps, 
Omnidroid won't be closed and I still remain in the activity with title 
"Add filters and actions to your rule!". I think a screen cast would be 
very helpful if you can provide one.

Thanks!

Original comment by renc...@gmail.com on 2 Jun 2010 at 4:32

GoogleCodeExporter commented 9 years ago 
Sorry about the video quality, but this should give you the exact actions taken.

Original comment by case.and...@gmail.com on 2 Jun 2010 at 5:45

Attachments:

GoogleCodeExporter commented 9 years ago 
I just did a wipe user data and re-installed and subsequently couldn't 
reproduce the
problem on the emulator although the version installed on my phone (0.1.2) 
still has
the problem.  I bet if I removed it completely from the phone and then 
downloaded it
from the market again the problem would go away.  But then we loose the user
configured data.  Possibly a problem with the class renames.

Original comment by case.and...@gmail.com on 2 Jun 2010 at 6:05

GoogleCodeExporter commented 9 years ago 
Sorry, I didn't quite understand what you meant by class renames. Are you 
talking about 
the directory reorganization we did recently? Thanks!

Original comment by renc...@gmail.com on 2 Jun 2010 at 8:14

GoogleCodeExporter commented 9 years ago 
Yes exactly.  A possible reflexivity issue that Evan warned about.

Original comment by case.and...@gmail.com on 3 Jun 2010 at 9:28

GoogleCodeExporter commented 9 years ago 
So, how are we going to deal with this issue? Is it good to close it?

Original comment by renc...@gmail.com on 15 Jun 2010 at 1:07

GoogleCodeExporter commented 9 years ago 
I think the changes to the db in Issue71 should help avoid this in the future 
if that was the cause of the problem.  If the db data was the problem, a 
possible solution would be to have a db update that drops all the data from the 
db and recreate it from scratch.  Of course that would lose all user stored 
rules as well, but I don't think that's a big concern at this time.

Original comment by case.and...@gmail.com on 15 Jun 2010 at 1:31

GoogleCodeExporter commented 9 years ago 
So I think the strategy here is before the 1.0 release we'll probably want to 
make sure there is a database reset.

Original comment by case.and...@gmail.com on 22 Jun 2010 at 8:36

GoogleCodeExporter commented 9 years ago 
This could also be a duplicate of Issue 94.  Regardless, I'll take care of this 
when we go to release.

Original comment by case.and...@gmail.com on 2 Jul 2010 at 9:30

GoogleCodeExporter commented 9 years ago

Original comment by case.and...@gmail.com on 6 Jul 2010 at 2:21

GoogleCodeExporter commented 9 years ago 
I think I found a way to update the database so we won't need to wipe user 
data.  Continue with standard database upgrade techniques until I can verify 
this (current plans to ditch the database and wipe any data are now on hold.)

Original comment by case.and...@gmail.com on 2 Aug 2010 at 9:47

GoogleCodeExporter commented 9 years ago 
Awaiting code review: http://codereview.appspot.com/1899045/show

Original comment by case.and...@gmail.com on 3 Aug 2010 at 1:28

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r850.

Original comment by case.and...@gmail.com on 5 Aug 2010 at 2:51