Closed GoogleCodeExporter closed 9 years ago
Started to take a look at this issue.
Original comment by renc...@gmail.com
on 2 Jun 2010 at 7:14
Summary of changes made for first version of implementation:
The controller.external.helper.telephony package:
Created a simple set of classes using the state pattern to keep track of the
phone's
state. You can also refer to the link below for the overview of the states:
http://code.google.com/p/omnidroid/wiki/PhoneCallStateTransition
PhoneStateMonitor (originally PhoneRingingMonitor, renamed to reflect its new
function)
Added functionality to detect phone call ended. See code documentation for more
details.
PhoneCallEvent:
Mostly original contents from the original PhoneRingingEvent, refactored into a
new
abstract base class.
PhoneRingingEvent:
Basically the same functionality as before, with most functionality delegated
to the
new base class.
CallEndedEvent:
The newly created event. See code documentation for more details.
The rest:
Other boiler plate codes needed, following http://codereview.appspot.com/890043.
Emulator Tests:
1. Simple phone ended rule, both inbound and outbound, with and without time
filter.
2. Checked that ring -> idle transition does not trigger the call ended event.
3. Checked the phone ringing rule works as before, with and without number and
time
filters.
Reminder:
Since this change is going to modify the database entry, you need to uninstall
the
app and upload it again to see the new event.
Original comment by renc...@gmail.com
on 5 Jun 2010 at 1:40
[deleted comment]
Requested code review:
http://codereview.appspot.com/1533043/show
Original comment by renc...@gmail.com
on 5 Jun 2010 at 2:01
Commited in r742
Original comment by renc...@gmail.com
on 9 Jun 2010 at 3:38
Original issue reported on code.google.com by
case.and...@gmail.com
on 27 May 2010 at 11:13