search

joelmccracken / reddup

Helping you keep your workstation nice and tidy
BSD 3-Clause "New" or "Revised" License
31 stars 6 forks source link

refactor to use fold and Fold #1

Closed goosetherumfoodle closed 7 years ago

goosetherumfoodle commented 7 years ago

Don't know if this is the correct logic or not because main errors out on me (even before my changes) and the tests complain about not being implemented. :woman_shrugging:

I assumed from seeing the word "filter" that the desired behavior was to remove the empty items. But now that I'm looking at the diff, it looks more like what you wanted was more of a map and stick mzeros in the empty slots.

So let me know if this breaks the logic or not.

joelmccracken commented 7 years ago

conceptually, the goal is to take each git local branch and see if there is a remote branch that contains it. Remove any local branches (from the Shell) that are contained by a remote git branch.

goosetherumfoodle commented 7 years ago

Ah ok. So I got the conditional logic flipped.

joelmccracken commented 7 years ago

I figured out how to fix it. Easiest way for me is just to make another commit on master after rebasing your change :P