joelmccracken / reddup

Helping you keep your workstation nice and tidy
BSD 3-Clause "New" or "Revised" License
31 stars 6 forks source link

Issue #20 #21

Closed Timoniche closed 4 years ago

Timoniche commented 4 years ago

Hello! There were maintaining tokens points in this issue. So far I added field and handled it, which tokens aka {datetime} do u like to add?

joelmccracken commented 4 years ago

So, my initial thought when I saw this feature request was "just add a custom handler" and then use bash to define what the current datetime is.

So the (partial) config would be:

handlers:
  git:
    commands:
      - name: WIP with (d)ate
        cmd: git add -a ; git commit -m "WIP $(date)"
        key: d

... and then we might add this to the "library" of potential other handlers. The downside here is that the original WIP commit option will still be there.

I wonder, would it be better to allow for "overriding" commands with hotkeys? so if you specify the same key/name, the default ones provided "disappear" from the menu, and instead it would show yours?

Thoughts @dariooddenino, especially re: #20?

IMO, Ideally we would steer people towards defining custom handlers whenever practical instead of adding "tweaks" to the data model here.

dariooddenino commented 4 years ago

I think overriding would be good.

joelmccracken commented 4 years ago

this is OBE #22