joelpt / sidewise

Persistent sidebar extension for Chrome featuring tree style tabs and tab hibernation.
Creative Commons Zero v1.0 Universal
68 stars 13 forks source link

Tree structure and hibernated tabs lost sometimes on startup #41

Open Wizek opened 11 years ago

Wizek commented 11 years ago

In the past 3-4 weeks I noticed that my entire session is wiped out sometimes when I start chrome.

The first time I lost ~1100 hibernated tabs that accumulated in the past months. It was frustrating, but hey, at least Sidewise got noticeably faster due to the lesser load.

Yesterday it happened again, and here is what I noticed: my computer overheated so it was an instant and unexpected shut-down. When booting back up, chrome asked me whether to restore the previous open tabs, and sidewise only displayed those, forgetting about all the hibernated ones, the tree structure relations of the open ones, highlights or folders.

In the options, I have these set to true:

Wizek commented 11 years ago

Update: Even if I cleanly exit ("Wrench" menu > Exit) Chrome, all my Sidewise data seems to get lost just as I described above.

Except for the handful open tabs which chrome takes note of.

@joelpt Do you have any idea what might cause this?

joelpt commented 11 years ago

I can't seem to reproduce this problem here. That being said, I think some changes in my latest dev build may correct what I'm guessing is causing this.

Would you be interested in running the dev build to see if it corrects the problem? It sounds like you have an easily reproducible case on your system.

Wizek commented 11 years ago

Yeah the next time I boot up my Windows OS I'll give it a shot. Is there a specific revision I should test with?

joelpt commented 11 years ago

I've just released a hotfix for this problem. If you can still reproduce this problem, can you update Sidewise and see if this fixes your problem?

Related Userecho thread: http://sidewise.userecho.com/topic/145990-lost-all-hibernated-tabs-and-folders-on-reboot/ Changelog: http://www.sidewise.info/changelog/

Wizek commented 11 years ago

The issue remains on my Windows OS: http://screencast.com/t/oUOyFbXnOv8z

joelpt commented 11 years ago

Thank you for the screencast, very helpful in understanding the situation. Very strange behavior! It looks like the tree isn't even being saved/loaded at all.

Could you please do the following? This will hopefully narrow down the problem to the specific cause, or at least help me see whether the problem is happening before or after the Chrome restart.

Thanks so much for your help diagnosing this one. With a little luck the above information will be enough to track down what's going awry here.

Wizek commented 11 years ago

When Chrome comes back up, is that hibernated window still in the tree?

No, it is gone.

Sent you the diagnostics.

joelpt commented 11 years ago

Thanks for the report. Stranger and stranger ...

Unfortunately I didn't get enough from the logs to nail down the cause. But it is strange - in your "after restart" log, most of the usual startup-time diagnostic information is simply not there. Did you by chance turn off "Enable diagnostics" before the restart and turn it back on after? If so that would explain the missing info in the second log, which may tell me more about the primary issue.

If you didn't turn it off, I'm currently stumped as to what could be causing this problem. Though it would lead me to think the empty-tree issue and the missing-log issue could be caused by the same underlying bug.

I am planning on publishing a "Sidewise Early Release" build soon (probably next week). When that is ready would you be interested in trying it and seeing if this problem persists for you there? That new build has some changes to how Sidewise handles Chrome shutdown that may address the issue; failing that, I have also improved the diagnostics to capture more information.

Wizek commented 11 years ago

Did you by chance turn off "Enable diagnostics" before the restart and turn it back on after?

Well, I didn't turn the diagnostics off, it was off when I started chrome back again, and turned it on to be able to send you the logs. I guess it doesn't save the the settings either.

Wizek commented 11 years ago

I am planning on publishing a "Sidewise Early Release" build soon (probably next week). When that is ready would you be interested in trying it and seeing if this problem persists for you there?

Sure.