Some minor changes - Githubissues

akalongman commented 11 years ago

Added capability to save file backup when file open (without saving) Changed datetime format from YYYY-MM-DD-HH-MM-SS to YYYY-MM-DD_HH-MM-SS

joelpt commented 11 years ago

I am going to merge this shortly, with the following additional modifications:

Modified the regex pattern in find_backups() so that it matches both the new style _ and old style - datepart/timepart separator character in backup filenames. This will let us retain compatibility with existing backup files that use the old style.
Added your new backup-on-open functionality contingent on a new setting "backup_on_open_file": false. I am defaulting this to false because I don't think most users will want it enabled; having it enabled generates a lot more backup files. For example, every time you start ST2, all the open tabs get backed up, and single-clicking a file under FOLDERS in the sidebar backs it up.
Extracted common code between on_load() and on_post_save() into new method save_view_to_backup().

Something that I think would really improve the behavior of backup_on_open_file (as well as AutomaticBackups in general): only save a backup copy if the new backup copy is different than the previous backup copy. This would mostly eliminate the aforementioned disadvantages of enabling backup_on_open_file.

joelpt commented 11 years ago

Completed with aforementioned modifications. https://github.com/joelpt/sublimetext-automatic-backups/commit/d5d096c5d42d6c7d88e699dc505f25c3f01d6549 https://github.com/joelpt/sublimetext-automatic-backups/commit/2deaf6ac42b71d1f172bfc7b64a8009ff941d417

joelpt / sublimetext-automatic-backups

Some minor changes #6