Merge tag 'v4.0.1' into develop - Githubissues

joelpurra / talkie

Text-to-speech browser extension button. Select text on any web page, and have the computer read it out loud for you by simply clicking the Talkie button.

https://joelpurra.com/projects/talkie/

GNU General Public License v3.0

71 stars 18 forks source link

Merge tag 'v4.0.1' into develop #10

Closed francisrs closed 7 years ago

francisrs commented 7 years ago

v4.0.1

tag 'v4.0.1': 4.0.1

Please fill out the following to help us help you. Replace ... with your own values, where applicable. Tick of the applicable items in the checklists with [x].

Description

...

Steps to verify functionality

...

General checklist

[x] The code works as expected.
[x] All tests pass.
[x] The pull request follows the steps for a git-flow feature.
[x] The pull request has been made against the develop branch.

Translation checklist

[x] All messages shown or spoken to the user are using chrome.i18n.getMessage("myMessageName").
[x] Any new or changed message string have been updated in _locales/en/base.json.
[x] Any new or changed message string have been updated in _locales/*/override.json for languages you know.

Code checklist

[x] The code has sanity checks (null values, string lengths, etcetera).
[x] Relevant functions and passages uses promiseTry(() => { ... }) with return and throw statements.
[x] Errors are handled gracefully.

Additional information

...

joelpurra commented 7 years ago

Hey @francisrs!

It seems this pull request is empty. Did you mean to make some changes? If so, which? The pull request information (description etcetera) requested is also empty. Closing this as a mistake while using git =)