joelpurra / talkie

Text-to-speech browser extension button. Select text on any web page, and have the computer read it out loud for you by simply clicking the Talkie button.
https://joelpurra.com/projects/talkie/
GNU General Public License v3.0
70 stars 17 forks source link

working in ubuntu 16.04 #3

Closed Goddard closed 7 years ago

Goddard commented 7 years ago

I am using Vivaldi trying to get this working. Any reason why this wouldn't work?

joelpurra commented 7 years ago

@Goddard: my basic tests just gives me a pretty useless "unknown error" in the developer console output when I try to use Talkie to read a news article. Speaking test text in the Talkie options works well though, which is good news.

Seems there is some difference between the extension API in Google Chrome and Vivaldi, possibly related to getting the selected text from a page. This will require a bit more investigation. Do you have any clue as to what the specific problem might be? Can have a look tomorrow; if there's an API difference I will look for a workaround =)

Also, just to check: do you have any voices installed in Vivaldi? You can check in Talkie's options, but if that doesn't work try installing US English Female Text-to-speech (by Google).

Thanks for the report!

joelpurra commented 7 years ago

@Goddard: it seems that Vivaldi doesn't support chrome.tabs.detectLanguage, at least not on my machine, which is why there was an "unknown error". Fortunately, the page language is the last fallback when it comes to language detection (after detected text language, selected element language, parent elements languages). With this in mind, I do hope that other language and voice features in Vivaldi work as expected.

Can you confirm the fix, please? If there are additional problems, we can reopen the issue.

Another problem I noticed in Vivaldi was that keyboard shortcuts do not seem to work very well. Talkie's shortcuts are listed properly under chrome://extensions/configureCommands but do not have any effect. I've found several Vivaldi bug reports regarding shortcuts and extensions in the forums. I assume a fix will be coming at some point, so won't make changes to Talkie.

Thanks again =)

joelpurra commented 7 years ago

@Goddard: by the way, Talkie v2.0.1 is now available in the chrome web store. Please check which version you have installed in chrome://extensions/ as it should update automatically (at some point).

Goddard commented 7 years ago

running 2.0.2 now and it looks like it gets triggered, meaning it will change the icon from the play to the stop icon, but I hear no sound.

It works on chrome though.

joelpurra commented 7 years ago

@Goddard: hmm. Just tested locally, and it works to both right-click text and use the Talkie button in the toolbar.

joelpurra commented 7 years ago

@Goddard: haven't received any reply so far, so am closing this issue. Reply to reopen. Thanks!

Goddard commented 7 years ago

I am on vacation and haven't had a chance to test as of yet. I will give it a go. Thanks for the updates.

joelpurra commented 7 years ago

@Goddard: no worries =) It would be best for Talkie if any issues could be resolved, but figured I would clean up the issue only due to inactivity. Check again after your vacation, if you feel like it =)