search

joelpurra / talkie

Text-to-speech browser extension button. Select text on any web page, and have the computer read it out loud for you by simply clicking the Talkie button.
https://joelpurra.com/projects/talkie/
GNU General Public License v3.0
70 stars 17 forks source link

Use internal URL to options page #9

Closed joelpurra closed 7 years ago

joelpurra commented 7 years ago

Reported by @rob--w:

6) FYI: options.js references chrome://extensions?options=enfbcfmmdpdminapkflljhbfeejjhjjk. This URL has no use in Firefox (and the link cannot be opened in Chrome either because navigations to chrome://-URLs are blocked). You're already using browser.runtime.openOptionsPage, so this does not affect usability. The only potential use of this link is to allow the user to right-click, copy URL and paste it somewhere. So consider changing the link to chrome.runtime.getURL("/src/options/options.html") (or simply "/src/options/options.html").

joelpurra commented 7 years ago

Sure. While the current link, using openOptionsPage(), works I will update the link.

Incidentally, after testing a partial fix without openOptionsPage(), it seems as if the options are able to fit in the popup. This is an interesting way to display the options =)

joelpurra commented 7 years ago

Close in v3.0.0. Thanks for reporting!