search

joelshepherd / tabliss

A beautiful, customisable New Tab page for Firefox, Chrome, and Edge.
https://tabliss.io
GNU General Public License v3.0
2.15k stars 281 forks source link

Github calendar username link doesn't work #595

Open chill389cc opened 1 year ago

chill389cc commented 1 year ago

I'm using the Github calendar widget but the element that wraps around it is linking to https://github.com instead of https://github.com/myUsername. Looking at the source code, it looks like it is supposed to include the username in the link but somehow data.username on this line is not getting populated (or something like that) and so the is left without the username in the link. Anyone else know what might be causing this, or if it is just me?

Steps required to reproduce:

  • Enable the Github Calendar widget
  • add your username in the widget settings
  • After the calendar appears, click on it.
  • Note that you are redirected to github.com without the /username piece.
chill389cc commented 1 year ago

I just cloned the repo and ran it locally and the username linking is working locally. It looks like that was pushed only a couple months ago. When will a new version of the extension be released?

the-wright-jamie commented 11 months ago

An update hasn't been released for over a year. I created a fork and release updates regularly, and I've also added a few features of my own. Included in it is this change, and a fix for #620, among other things!

https://github.com/the-wright-jamie/tab-nine