search

joelshepherd / tabliss

A beautiful, customisable New Tab page for Firefox, Chrome, and Edge.
https://tabliss.io
GNU General Public License v3.0
2.15k stars 281 forks source link

Cannot fetch They Said So quotes due to CORS issue #601

Open Ray-Eldath opened 1 year ago

Ray-Eldath commented 1 year ago

Don't know why this happened. But seems They Said So keeps returning CORS error and a 401 Unauthorized.

image image

Mv0sKff commented 1 year ago

Same problem on Firefox. Looks like they changed the api

jeremylaier-tc commented 1 year ago

Not a cors issue. Tabliss API key is expired.

mocadev1 commented 1 year ago

I recently installed the extension and wanted to know why the They Said So option for quotes didn't work, so I went to the website and I noticed this:

Please note recently we closed down public access without api key to prevent abuse.

I haven't read source (tabliss) and don't know API releases dates, but I would infer the quoted (ironically) phrase above is the reason this widget doesn't work.

Mv0sKff commented 1 year ago

Well, I made a hacky fork that shows a quote from a couple of hard coded ones that I copied from https://github.com/dwyl/quotes for myself. There is a release for Chrome and Firefox https://github.com/Mv0sKff/tabliss_offline_quotes

Would be great if this issue would be addressed

marcodussin commented 1 year ago

Latest merge is 4 months ago. Time to fork the project?

sirlupusdev commented 1 year ago

I'm currently trying to add the functionality of supplying an API key in .env and then including that when building the extension in my fork. My initial plan was then to post a explanation on how to build and migrate the extension but there's still one issue.

The code in itself is already done, however, I'm still running into the CORS issue. When looking at the Preflight response headers, it seems like the API is not sending an Access Control Header when sending a 401 response even though they state it on their website, thus the browser not even sending the actual request with the auth header. Please correct me if I'm wrong in this case.

I've reached out to the TheySaidSo API via their Contact form, I guess we'll have to wait for them to change something.

maikol-solis commented 1 year ago

Well, I made a hacky fork that shows a quote from a couple of hard coded ones that I copied from https://github.com/dwyl/quotes for myself. There is a release for Chrome and Firefox https://github.com/Mv0sKff/tabliss_offline_quotes

Hi, I tried to install your version, but I got this error.

image

Thanks.

Mv0sKff commented 1 year ago

@maikol-solis Try installing it from here https://addons.mozilla.org/en-US/firefox/addon/tabliss-offline-quotes/

maikol-solis commented 1 year ago

@Mv0sKff It works flawlessly. Thanks!

However, I'm confused because all the categories in the settings sidebar aren't really used, or am I wrong?

Image

Mv0sKff commented 1 year ago

No, you are right. Choosing a category does nothing.

These are all the quotes that show up at random: src/plugins/widgets/quote/quotes.ts

maikol-solis commented 1 year ago

Ok perfect. The add-on works perfectly fine. I just wanted to be sure about this.

Thanks to revive this feature.

the-wright-jamie commented 11 months ago

Latest merge is 4 months ago. Time to fork the project?

Yeah, last update to stores was 2022, I forked and am going through updating packages and rebranding for a re-release. Anyone have any ideas or feature suggestions or pull requests they'll definitely be seen by an active dev

https://github.com/the-wright-jamie/tab-nine

Working on some changes so it's not pretty right now and no release but I'm hoping to clean up some of the bit rot

Release available: https://github.com/the-wright-jamie/tab-nine#download