search

joelspadin-garmin / vscode-private-extension-manager

Private extension manager for Visual Studio Code
103 stars 22 forks source link

Add support for insecure content #45

Closed r-hadrich closed 3 years ago

r-hadrich commented 3 years ago

Hello! As npm servers do not allow to upload images along the README file, the only possibility is to store the images externally. Since creating a recognized certificate just to host a couple of images internally may be too much hassle, I thought it may be a good idea to add to this extension the optional possibility to accept http content inside markdown preview. Here's an implementation of this idea, it doesn't induce much changes in the code.

joelspadin-garmin commented 3 years ago

Thanks for this! GitHub actions seem to be having trouble at the moment though, so I'll try restarting them again later.

r-hadrich commented 3 years ago

Sure. Thank you for this great extension.

joelspadin-garmin commented 3 years ago

As far as I can tell, the failed test is probably due to changes in newer versions of VS Code and/or the vscode-test library. The tests assume the extension is installed and activated, and that doesn't seem to be happening anymore. It's not related to this change.

r-hadrich commented 3 years ago

As I see it's only a problem with the remote-helper tests, and it occurred in older commits too. Either way, please let me know when it will get released.

joelspadin-garmin commented 3 years ago

I just published v1.6.0 with these changes. (The remote-helper tests ended up being that the tests were compiled when running npm test, but the extension itself wasn't.)