search

joelspadin-garmin / vscode-private-extension-manager

Private extension manager for Visual Studio Code
102 stars 22 forks source link

Ignoring engines/vscode version #49

Open DiefBell opened 3 years ago

DiefBell commented 3 years ago

Private Extension Manager is showing extension versions that are incompatible with the version of VS Code it's running on. Is this a bug, or are we expected to check this ourselves when uploading extensions to our NPM registry?

This was observed on VS Code 1.56.2, finding GitLens 11.2.1 (wants vscode ^1.57.0). I think 1.57.0 is an insider version, so that may be a source of issues.

joelspadin-garmin commented 3 years ago

I never implemented any checks for this since I figured people would normally keep VS Code up to date, so it wasn't worth the extra time to add it. I will certainly accept a PR to add it though.

The current stable version of VS Code is 1.57. Also, are you uploading extensions like GitLens that are available on the marketplace to your private registry? That was never an intended use case, so I don't know what how well Private Extension Manager will handle an extension that is also being managed by the built-in extensions manager.

DiefBell commented 3 years ago

Our environment is airgapped so our VS Code version is rarely up-to-date. We have a script that can re-pack VSIX files and automatically push them to our npm registry. I'll look into making another PR for the checks.

joelspadin-garmin commented 3 years ago

Since with your use case you can't actually use the regular extensions marketplace, you might also want to look at using Open VSX and replacing the extensions marketplace with your own registry: https://github.com/eclipse/openvsx/wiki/Using-Open-VSX-in-VS-Code

This extension is mostly a kludge to augment the extensions marketplace with a small number of private extensions. I've only tested it with a couple dozen extensions in the registry, and I suspect it needs some significant rework and optimization to handle large registries well.