search

joelspadin-garmin / vscode-private-extension-manager

Private extension manager for Visual Studio Code
103 stars 22 forks source link

Fix issue 44- bad SemVer comparison #59

Closed denielig closed 2 years ago

denielig commented 3 years ago

We need to use the "compare" method instead of > for comparison of 2 SemVer Objects

denielig commented 3 years ago

Hi Joel, Is it ok for you ? It's work fine for me !!!

joelspadin-garmin commented 3 years ago

The code change looks good to me, but I've been busy and haven't had time to test it yet. I'll try to get to it soon.

joelspadin-garmin commented 3 years ago

The CI checks found an issue. Could you please run prettier to fix the formatting?

denielig commented 3 years ago

Hi Joel, Can you please release this fix and the AutoUpdate feature ?

YvesMichon commented 2 years ago

Hi Joel, We have the same problem in our company because we have started new developments and the version number have reached 10. When are you planning to release the fix ?

joelspadin-garmin commented 2 years ago

Sorry. I have not had any free time to work on this until now.

denielig commented 2 years ago

Thanks you Joel 👍. But can you please downgrade the vscode engine version to 1.61.0 in the package.json ? I haven't already check all my private extension for the 1.63.0 version of VSCode.

joelspadin-garmin commented 2 years ago

I could, but it might be a while before I have free time again to do that. I bumped the minimum version because I only tested it on 1.63.0.

denielig commented 2 years ago

Ok. Forget my request. I upgraded to 1.63.0.