Closed nickcoutsos closed 1 year ago
do you have any thoughts about including generated files in versioning?
I don't really like it either, but based on https://github.com/tree-sitter/tree-sitter/issues/730, it sounds like this is currently done because it lets other tools just clone the repo and then compile the .c files. I'll gladly change this if they ever make a better system for this (seems unlikely given that the last update on this was three years ago).
Looks good to me. Thanks!
Minor change, especially as there's very little to these nodes, but it's a little nicer to work with than array access.
@joelspadin semi-related, do you have any thoughts about including generated files in versioning? I remember reading something about them being expected with some tree-sitter tooling but it means anytime there's more than one pull request in flight you end up with merge conflicts. In my case I have a different implementation of one feature and another that hasn't been merged in yet so I've been trying to maintain sets of changes across branches which I guess only works because I don't need to change things often.