search

joelverhagen / NCsvPerf

A test bench for various .NET CSV parsing libraries
https://www.joelverhagen.com/blog/2020/12/fastest-net-csv-parsers
MIT License
69 stars 14 forks source link

added TxtCsvHelper #32

Closed camdrudge closed 3 years ago

camdrudge commented 3 years ago

added new nuget package

camdrudge commented 3 years ago

I'm sorry, how do I include that then?

Sorry to be such a pain, like I said I'm fully self taught and I have little experience with Github and unit testing

On Thu, Jul 1, 2021 at 12:43 PM Joel Verhagen @.***> wrote:

@.**** commented on this pull request.

In NCsvPerf.Test/NCsvPerf.Test.csproj https://github.com/joelverhagen/NCsvPerf/pull/32#discussion_r662548815:

@@ -8,6 +8,7 @@

+ This is not needed since this reference will come in transitively from NCsvPerf.csproj. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or unsubscribe .
joelverhagen commented 3 years ago

I'm sorry, how do I include that then? Sorry to be such a pain, like I said I'm fully self taught and I have little experience with Github and unit testing

No problem :). Because the NCsvPerf.Test.csproj project file references the NCsvPerf.csproj project with a project reference, all of the package references in the latter will automatically flow in to the test project. This is why you don't see any other lines in NCsvPerf.Test.csproj for the other CSV parsing libraries that are being tested. You can simply delete that line that I commented on and run dotnet build again to see that it still works.

camdrudge commented 3 years ago

Okay, it should be fixed now!

On Thu, Jul 1, 2021 at 7:22 PM Joel Verhagen @.***> wrote:

I'm sorry, how do I include that then? Sorry to be such a pain, like I said I'm fully self taught and I have little experience with Github and unit testing

No problem :). Because the NCsvPerf.Test.csproj project file references the NCsvPerf.csproj project with a project reference, all of the package references in the latter will automatically flow in to the test project. This is why you don't see any other lines in NCsvPerf.Test.csproj for the other CSV parsing libraries that are being tested. You can simply delete that line that I commented on and run dotnet build again to see that it still works.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joelverhagen/NCsvPerf/pull/32#issuecomment-872665065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ7PX53RF3UR4H5EMZJCNTDTVUPGHANCNFSM47VJHBJA .

joelverhagen commented 3 years ago

Thanks Cameron!