joelvh / webpagetest

Automatically exported from code.google.com/p/webpagetest
0 stars 0 forks source link

Vague and possibly incorrect attributions #112

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In dist/webpagetest/license.txt Smarty and distorm are attributed, but I can 
find no evidence of these packages (copyright headers, function or class names, 
etc.).

Are these packages or source code from them still used in the distribution, and 
if not, can they be removed them from the attributions? If they are used, 
where? Can those files have their headers indicate so and retain copyright 
stamps?

Original issue reported on code.google.com by paulb...@amazon.com on 8 Sep 2012 at 11:03

GoogleCodeExporter commented 8 years ago
distorm is used by the Windows agents and is in 2 places in the source tree 
(licenses and headers intact):

http://webpagetest.googlecode.com/svn/trunk/agent/browser/ie/pagetest/distorm/
http://webpagetest.googlecode.com/svn/trunk/agent/wpthook/distorm/

Smarty is used by the WPT Monitor project which isn't part of WPT proper but is 
in the same repository.  I'm not sure exactly where in the code it is used but 
I'm pretty sure it's fundamental to how the project runs.

http://webpagetest.googlecode.com/svn/trunk/www/wptmonitor/

Original comment by PatMee...@gmail.com on 8 Sep 2012 at 11:33

GoogleCodeExporter commented 8 years ago
Thank you!

Original comment by paulb...@amazon.com on 8 Sep 2012 at 11:37