Reading time indicator - Githubissues

joemccann / dillinger

The last Markdown editor, ever.

https://dillinger.io

MIT License

7.95k stars 1.11k forks source link

Reading time indicator #786

Closed valentinkononov closed 3 years ago

valentinkononov commented 3 years ago

Dillinger is an awesome tool. I searched for something like this to work on MD online.

But I wanted to have easy to use reading time indicator -> forked code and made a change. @crohr @dscape @mattcone @joemccann @swang please take a look and update tool if you consider this as a useful change

what was changed:

[x] updated wordCount service to use npm library reading-time. it counts words and reading time in medium like manner
[x] remove characterCount service -> moved it's functionality to wordCount service
[x] add indicator to headers
[x] update package.json to fix issue with local running with gulp (https://stackoverflow.com/questions/55921442/how-to-fix-referenceerror-primordials-is-not-defined-in-node)

joemccann commented 3 years ago

Wow this is awesome! Will get it merged ASAP.

joemccann commented 3 years ago

Ok so I tested your branch and it worked fine but after I merged and rebuilt I'm getting this issue:

Seems like something with the bundle?

joemccann commented 3 years ago

@valentinkononov can you please try pulling down the latest and building from scratch to see what the issue is?

valentinkononov commented 3 years ago

Yep, will check it tomorrow. Thanks!

On Sat, 13 Feb 2021 at 19:10, Joe McCann notifications@github.com wrote:

@valentinkononov https://github.com/valentinkononov can you please try pulling down the latest and building from scratch to see what the issue is?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/pull/786#issuecomment-778632008, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHSYMMBB64OUFPCER3K6CTS62I7LANCNFSM4XGB5FZA .

-- Best regards, Valentin Kononov