joemccann / dillinger

The last Markdown editor, ever.
https://dillinger.io
MIT License
7.98k stars 1.11k forks source link

[BUG] GitHub service broken #813

Closed SimonKraus closed 2 years ago

SimonKraus commented 3 years ago

The GitHub oAuth workflow stopped working few weeks ago.

When trying to link to GitHub you will get an 404 not found error.

justinphilpott commented 3 years ago

Bump...

joemccann commented 3 years ago

Pull requests accepted

On Sun, Oct 10, 2021 at 17:03 Justin Philpott @.***> wrote:

Bump...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/813#issuecomment-939577902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2U5SZXH3GIZCI42US3UGISVPANCNFSM5BOGID3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Joe in Real Life

justinphilpott commented 3 years ago

Hi Joe,

I'd love to help with this, can you give me any pointers on this specific issue?

Thank you, Justin

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, October 11th, 2021 at 01:26, Joe McCann @.***> wrote:

Pull requests accepted

On Sun, Oct 10, 2021 at 17:03 Justin Philpott @.***> wrote:

Bump...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/813#issuecomment-939577902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2U5SZXH3GIZCI42US3UGISVPANCNFSM5BOGID3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Joe in Real Life

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

joemccann commented 3 years ago

Looks like the GitHub plugin is out of date and needs to be updated

On Mon, Oct 11, 2021 at 00:38 Justin Philpott @.***> wrote:

Hi Joe,

I'd love to help with this, can you give me any pointers on this specific issue?

Thank you, Justin

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, October 11th, 2021 at 01:26, Joe McCann @.***> wrote:

Pull requests accepted

On Sun, Oct 10, 2021 at 17:03 Justin Philpott @.***> wrote:

Bump...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/joemccann/dillinger/issues/813#issuecomment-939577902>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAALY2U5SZXH3GIZCI42US3UGISVPANCNFSM5BOGID3A

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

-- Sent from Joe in Real Life

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/813#issuecomment-939769157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2VQP6IMZ5RUITI2JETUGKH67ANCNFSM5BOGID3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Joe in Real Life

suredream commented 3 years ago

me too. When select "link to github" services, a 404 error came out.

joemccann commented 3 years ago

Pull requests accepted

On Mon, Nov 1, 2021 at 20:25 Jun Xiong @.***> wrote:

me too. When select "link to github" services, a 404 error came out.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/813#issuecomment-957067582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2VI6P3DWM4XLX62WUDUJ5K37ANCNFSM5BOGID3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Joe in Real Life

nmharmon8 commented 2 years ago

Looks like the client ID dose not get populated in the url.

Current: https://github.com/login/oauth/authorize?scope=repo&redirect_uri=http://localhost:12345/oauth/github

Required: https://github.com/login/oauth/authorize?client_id=&scope=repo&redirect_uri=http://localhost:12345/oauth/github

Still investigating

nmharmon8 commented 2 years ago

I think it works now see pull request #832

cc6580 commented 2 years ago

I am still get the 404 error, any workarounds?

nmharmon8 commented 2 years ago

That was all it took to get it working for me.

Potherca commented 2 years ago

@cc6580 Could be related to the latest version not yet being deployed to Dillinger.io? https://github.com/joemccann/dillinger/issues/834

joemccann commented 2 years ago

Correct

On Fri, Apr 8, 2022 at 03:09 Ben Peachey @.***> wrote:

@cc6580 https://github.com/cc6580 Could be related to the latest version not yet being deployed to Dillinger.io? #834 https://github.com/joemccann/dillinger/issues/834

— Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/813#issuecomment-1092698904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2VSK6C63AKY32I37TLVEAAT5ANCNFSM5BOGID3A . You are receiving this because you commented.Message ID: @.***>

-- Sent from Joe in Real Life

joemccann commented 2 years ago

I redeployed. Try now.

Potherca commented 2 years ago

I tried logging in with GitHub on https://dillinger.io/, everything worked as expected. 👍

cc6580 commented 2 years ago

I redeployed. Try now.

Everything works now. Thanks!