joemccann / dillinger

The last Markdown editor, ever.
https://dillinger.io
MIT License
7.9k stars 1.1k forks source link

Docker build is broken! Here's the fix Microsoft guy! #819

Closed cigzigwon closed 2 years ago

cigzigwon commented 2 years ago

I like to use your editor but your Docker build is broken!!! See the fixes/comments in the gist: dillinder.Dockerfile

joemccann commented 2 years ago

Pull requests accepted

On Sun, Sep 19, 2021 at 08:14 Chris Sobeck @.***> wrote:

I like to use your editor but your Docker build is broken!!! See the fixes/comments in the gist: dillinder.Dockerfile https://gist.github.com/cigzigwon/4e74dab4bfd2076f8e27a70fa005a600

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/819, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2QV6QM5G6LSHVE52NLUCX45FANCNFSM5EKN33OA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Joe in Real Life

cigzigwon commented 2 years ago

Ok...

The google drive plugin also didn't work and had to make another change for that. It's working on my end but I circle back around with a cleaner Dockerfile. The plugin part just has diff interface. It's supposed to be var { google } = require("googleapis")

cigzigwon commented 2 years ago

@joemccann Ouch dude! The coding is good but you made a booboo somewhere along the line w/package versioning. I'm almost out of the weeds but I think you've been working at Microsoft for too long...

joemccann commented 2 years ago

Please do not contribute this project. Your toxic attitude is not welcome.

On Sun, Sep 19, 2021 at 16:29 Chris Sobeck @.***> wrote:

@joemccann https://github.com/joemccann Ouch dude! The coding is good but you made a booboo somewhere along the line w/package versioning. I'm almost out of the weeds but I think you've been working at Microsoft for too long...

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/819#issuecomment-922555444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2Q7UQAUDXTMN6D462DUCZW5BANCNFSM5EKN33OA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sent from Joe in Real Life

cigzigwon commented 2 years ago

@joemccann No worries. I don't have to work at Microsoft

cigzigwon commented 2 years ago

Here's my synopsis. If anyone wants to roll this into their own stack via Docker they will have problems due to including transpiled assets into the repo. Theres no way to compile correctly with that container because it's not setup right to do that. You can see the re-written docker file in my fork but as of now there is no way to dev assets for the front end. Several errors occur with gulp, missing gulp-cli. Your package scripts don't align with the README file either. The main issue is that your compiled assets DO NOT WORK with googleapis 39.1.0 but I was able to hack the responses so that they do. I don't allow for Node or NPM to be installed locally. I'm not toxic I don't like Microsoft. Has nothing to do with you personally, it's just a joke. I'm a bit of a sociopath so I may seem offensive. I just want to say that the Dillinger project is great!