joemccann / dillinger

The last Markdown editor, ever.
https://dillinger.io
MIT License
7.9k stars 1.1k forks source link

Updated katex math support to a newer package (markdown-it-texmath) #845

Closed TurboSlayer closed 1 year ago

TurboSlayer commented 1 year ago

Changes:

Documentation ideas:

Notes:

joemccann commented 1 year ago

Can you get node 18 with gulp working?

TurboSlayer commented 1 year ago

Yep, but I used that as a workaround just to get the app working, then reverted the changes so that it wouldn't affect the live version. Basically I used the newer "overrides" setting instead of npm-force-resolutions - see https://stackoverflow.com/a/58394828.

Also, please see if it works on node 10 or whatever version the live service is using as I have not tested that.

joemccann commented 1 year ago

yeah we desperately need to move on from gulp and the old webpack -- I've spent hours trying to update it but to no avail

On Mon, Nov 28, 2022 at 5:46 PM TurboSlayer @.***> wrote:

Yep, but I used that as a workaround just to get the app working, then reverted the changes so that it wouldn't affect the live version. Basically I used the newer "overrides" setting instead of npm-force-resolutions - see https://stackoverflow.com/a/58394828.

— Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/pull/845#issuecomment-1329967819, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2QLK2R6IIA7NQGTMR3WKVN6ZANCNFSM6AAAAAASM73GMI . You are receiving this because you modified the open/close state.Message ID: @.***>

TurboSlayer commented 1 year ago

Yeah that does seem quite daunting. I assume the upgrade/gulp-4 branch is what you’ve got so far?

joemccann commented 1 year ago

Yes

On Mon, Nov 28, 2022 at 18:50 TurboSlayer @.***> wrote:

Yeah that does seem quite daunting. I assume the upgrade/gulp-4 branch is what you’ve got so far?

— Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/pull/845#issuecomment-1330005199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2SVDYAZN3QRZKVFAKDWKVVPNANCNFSM6AAAAAASM73GMI . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Sent from Joe in Real Life

TurboSlayer commented 1 year ago

Oh well, I could take a look but I doubt I'd get any further so good luck. Hopefully someone will save us one day...