search

joemccann / dillinger

The last Markdown editor, ever.
https://dillinger.io
MIT License
7.9k stars 1.1k forks source link

Is this repo still maintained? README vastly out of date (not even node 16 supported) #853

Open corneliusroemer opened 1 year ago

corneliusroemer commented 1 year ago

Unfortunately it appears that this repo is no longer maintained. But there's no sign of that in the README.

E.g. the README still claims that all versions post node v10+ are supported. But I failed to get it to build with node 18 LTS or node 20. node-sass seems to required Python 2 (!), see https://github.com/joemccann/dillinger/issues/848

The repo owner @joemccann seems to be aware of the fact that right now this won't build with node 16 or later (see https://github.com/joemccann/dillinger/issues/839). It would be nice if this was acknowledged in the README. I'm happy to update the README in a PR.

joemccann commented 1 year ago

Submit a PR and I'll merge it!

On Thu, May 18, 2023 at 15:42 Cornelius Roemer @.***> wrote:

Unfortunately it appears that this repo is no longer maintained. But there's no sign of that in the README.

E.g. the README still claims that all versions post node v10+ are supported. But I failed to get it to build with node 18 LTS or node 20. node-sass seems to required Python 2 (!), see #848 https://github.com/joemccann/dillinger/issues/848

The repo owner @joemccann https://github.com/joemccann seems to be aware of the fact that right now this won't build with node 16 or later (see #839 https://github.com/joemccann/dillinger/issues/839). It would be nice if this was acknowledged in the README. I'm happy to update the README in a PR.

— Reply to this email directly, view it on GitHub https://github.com/joemccann/dillinger/issues/853, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALY2VTKFDBW7XW4SQFMXDXGZ3SNANCNFSM6AAAAAAYG4COVI . You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from Joe in Real Life

corneliusroemer commented 1 year ago

Thanks @joemccann! Can you give me quick info about how you host it? Which node version does it work with? How would you recommend devs to run it if they want to? Using docker?

joemccann commented 1 year ago

The docker file likely needs to be updated but all the docs are in the README

joemccann commented 1 year ago

The docker file likely needs to be updated but all the docs are in the README