Fixed #1: improved query building support

joemfb / ml-common-ng

An angular module of common components for the MarkLogic REST API

https://joemfb.github.io/ml-common-ng/

2 stars 2 forks source link

Fixed #1: improved query building support #11

Closed grtjn closed 9 years ago

grtjn commented 9 years ago

Fixes #1, and testing of #4.

grtjn commented 9 years ago

I tried to remain backwards-compatible as much as possible. Exceptions:

Meaning of collection() has changed from collection-constraint-query to collection-query (you now have a collectionConstraint function.
Implementation of properties() was wrong, there is no such thing as a properties-query, so I changed that into properties-fragment-query (also exposed as propertiesFragment())

joemfb commented 9 years ago

This PR is being kept open for now, until all the methods within it are added as part of #14 and #15, at which point it will be closed.

grtjn commented 9 years ago

I could try rebasing, and redoing part of the work on top of your latest work. Not sure I'll be able to work on that on short notice. Feel free to open a PR of your own for it..

joemfb commented 9 years ago

I don't think it's worth your trouble. I want to split the work across multiple releases, need to add tests, verify signatures against the node-client-api, etc.

Still, the implementations are very valuable, and I'll use them as the basis for future PRs.

joemfb commented 9 years ago

This PR is fully covered by merged PRs #16 and #17, open PR #18, and open issue #20.