search

joemfb / ml-common-ng

An angular module of common components for the MarkLogic REST API
https://joemfb.github.io/ml-common-ng/
2 stars 2 forks source link

Fixed #4: added compile directive #9

Closed grtjn closed 9 years ago

grtjn commented 9 years ago

Fixes #4

joemfb commented 9 years ago

Thanks, this looks good!

One change request: can you remove the second argument to angular.module()? I think that's duplicating the initialization of ml.common.

grtjn commented 9 years ago

You are right, I made a change, after testing in Splunk: http://plnkr.co/edit/Opiq0Et2xQAIPMcDU71V?p=preview. Looks much simpler as well, the $compileProvider didn't seem to be necessary.

joemfb commented 9 years ago

Awesome! Finally, can you squash your commits down to one?

grtjn commented 9 years ago

If you tell me how.. Is it very important? :-P

joemfb commented 9 years ago

It's just nice to keep the history clean with atomic commits.

git checkout 4-compile-directive
git rebase -i HEAD~2

replace "pick" with "squash" in second line. save when prompted, edit / combine commit messages save again git log to confirm that the two commits have been replaced with one

git push origin 4-compile-directive -f
grtjn commented 9 years ago

squash didn't seem enough, I used fixup instead. Anyhow, looks good now!

joemfb commented 9 years ago

Looks great!