joemfb / ml-search-ng

angular module for MarkLogic search applications
https://joemfb.github.io/ml-search-ng/
9 stars 10 forks source link

Added commas to ml results count and dynamic template. #113

Closed janmichaelyu closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling 635059603fc1f681f5c4f50e43bfbf02aa682328 on janmichaelyu:master into 5ef78846cd636042687245261414552bccbbae6f on joemfb:master.

joemfb commented 6 years ago

Thanks, @janmichaelyu! This looks great.

One request: can you remove the files in dist/ from this PR? I typically check those in all at once for new release commits.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling efdd25baf6cc8cb24ad2165ceb1d4ee76afd1b66 on janmichaelyu:master into 5ef78846cd636042687245261414552bccbbae6f on joemfb:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling 7206115de6f9ae34069cd53ce500f46300a14f9d on janmichaelyu:master into 5ef78846cd636042687245261414552bccbbae6f on joemfb:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling 7206115de6f9ae34069cd53ce500f46300a14f9d on janmichaelyu:master into 5ef78846cd636042687245261414552bccbbae6f on joemfb:master.

janmichaelyu commented 6 years ago

@joemfb I apologize for the messy commits, editing from the github site wasn't the right choice for me.

Anyway, I removed the dist files from this PR.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling 7206115de6f9ae34069cd53ce500f46300a14f9d on janmichaelyu:master into 5ef78846cd636042687245261414552bccbbae6f on joemfb:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling 1ebb190dae91bf156e8042d23e41815fafed897c on janmichaelyu:master into 5ef78846cd636042687245261414552bccbbae6f on joemfb:master.

joemfb commented 6 years ago

No problem, I'll squash on merge. Thanks!