joemfb / ml-search-ng

angular module for MarkLogic search applications
https://joemfb.github.io/ml-search-ng/
9 stars 10 forks source link

truncateLength not passed through (correctly) to ml-chiclets #95

Closed grtjn closed 8 years ago

grtjn commented 8 years ago

The truncate attribute takes a value, not a reference. In ml-facets.html, this:

truncate="truncateLength"

Should be:

truncate="{{truncateLength}}"

One could also argue, that you might want to have a slightly less truncateLength for chiclets, as the value gets prepended with the facet name, making it longer. Perhaps ml-chiclet should truncate facetname+value according to that length..

joemfb commented 8 years ago

Good find, thanks!

grtjn commented 8 years ago

Just a matter of using the features.. :)