joenas / huginn_github_notifications_agent

Huginn agent to fetch Github notifications
MIT License
5 stars 1 forks source link

Upgrade rubocop to version 0.87.0 #22

Closed depfu[bot] closed 4 years ago

depfu[bot] commented 4 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.83.0 → ~> 0.87.0) · Repo · Changelog

Release Notes

0.87.0

New features

  • #7868: Cop::Base is the new recommended base class for cops. (@marcandre)
  • #3983: Add new Style/AccessorGrouping cop. (@fatkodima)
  • #8244: Add new Style/BisectedAttrAccessor cop. (@fatkodima)
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. (@fatkodima)
  • #7373: Add new Style/RedundantAssignment cop. (@fatkodima)
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). (@koic)
  • #8159: Add new CountAsOne option for code length related Metric cops. (@fatkodima)
  • #8164: Support auto-correction for Lint/InterpolationCheck. (@koic)
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. (@koic)
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. (@koic)

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. (@CamilleDrapier)
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. (@fatkodima)
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. (@koic)
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. (@owst)
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. (@owst)
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. (@karlwithak)
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. (@deivid-rodriguez)

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. (@marcandre)
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. (@marcandre)
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. (@marcandre)
  • #8211: Style/ClassVars cop now detects class_variable_set. (@biinari)
  • #8245: Detect top-level constants like ::Const in various cops. (@biinari)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 4 years ago

Closed in favor of #23.