#8354: Detect regexp named captures in Style/CaseLikeIf cop. (@dsavochkin)
#8821: Fix an incorrect autocorrect for Style/NestedTernaryOperator when using a nested ternary operator expression with no parentheses on the outside. (@koic)
#8834: Fix a false positive for Style/ParenthesesAsGroupedExpression when method argument parentheses are omitted and hash argument key is enclosed in parentheses. (@koic)
#8830: Fix bad autocorrect of Style/StringConcatenation when string includes double quotes. (@tleish)
#8807: Fix a false positive for Style/RedundantCondition when using assignment by hash key access. (@koic)
#8848: Fix a false positive for Style/CombinableLoops when using the same method with different arguments. (@dvandersluis)
#8843: Fix an incorrect autocorrect for Lint/AmbiguousRegexpLiteral when sending method to regexp literal receiver. (@koic)
#8842: Save actual status to cache, except corrected. (@hatkyinc2)
#8835: Fix an incorrect autocorrect for Style/RedundantInterpolation when using string interpolation for non-operator methods. (@koic)
#8855: Fix an error for Layout/EmptyLinesAroundAccessModifier and Style/AccessModifierDeclarations when using only access modifier. (@koic)
Changes
#8803: (Breaking)RegexpNode#parsed_tree now processes regexps including interpolation (by blanking the interpolation before parsing, rather than skipping). (@owst)
#8625: Improve Style/RedundantRegexpCharacterClass and Style/RedundantRegexpEscape by using regexp_parser gem. (@owst)
#8646: Faster find of all files in TargetFinder class which improves initial startup speed. (@tleish)
#8102: Consider class length instead of block length for Struct.new. (@tejasbubane)
#7408: Make Gemspec/RequiredRubyVersion cop aware of Gem::Requirement. (@tejasbubane)
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.
All Depfu comment commands
@depfu rebase
Rebases against your default branch and redoes this update
@depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@depfu close
Closes this PR and deletes the branch
@depfu reopen
Restores the branch and reopens this PR (if it's closed)
@depfu pause
Ignores all future updates for this dependency and closes this PR
@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot]
commented
4 years ago
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.83.0 → ~> 0.93.0) · Repo · Changelog
Release Notes
0.93.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 59 commits:
Cut 0.93[Fix #8821] Fix an incorrect autocorrect for `Style/NestedTernaryOperator` (#8832)[Fix #8718] Fix undefined methods of pseudo location (#8823)Keep all specs in dot_position_specFix Cop/LayoutPosition autocorrectAdd tests for Layout/DotPosition cop[Fix #8834] Fix a false positive for `Style/ParenthesesAsGroupedExpression` (#8839)Add new `Style/ClassEqualityComparison` copMerge pull request #8861 from koic/fix_an_example_for_format_string_tokenMerge pull request #8856 from koic/fix_an_error_for_two_copsFix an example for `Style/FormatStringToken`[Fix #8855] Fix an error when using only access modifierMerge pull request #8822 from koic/make_style_redundant_begin_aware_of_begin_without_rescueMake `Style/RedundantBegin` aware of `begin` without `rescue`[Fix #7408] Make `Gemspec/RequiredRubyVersion` cop aware of `Gem::Requirement`[Fix #7495] Documentation for `Lint/AmbiguousBlockAssociation`[Fix #8804] Save actual status to cache (#8841)[Fix #8842] Add a message about loading the cache to the debug output (#8853)Merge pull request #8837 from koic/fix_incorrect_autocorrect_for_redundant_interpolation[Fix #8835] Fix an incorrect autocorrect for `Style/RedundantInterpolation`Fix a false positive for `Lint/BooleanSymbol` when used within `%i[...]`Merge pull request #8847 from koic/fix_incorrect_autocorrect_for_ambiguous_regexp_literal[Fix #8843] Fix an incorrect autocorrect for `Lint/AmbiguousRegexpLiteral`Merge pull request #8851 from dvandersluis/issue/8848Add new `Lint/RedundantSafeNavigation` copUse `regexp_parser` to improve `Style/RedundantRegexp...` cops (#8625)[Fix #8848] Fix a false positive for `Style/CombinableLoops` when using the same method with different arguments.Merge pull request #8807 from koic/fix_incorrect_autocorrect_for_redundant_conditionFix a false positive for `Style/RedundantCondition`Merge pull request #8840 from tleish/style-string-concatenation-with-double-quotesFix #8830 bad autocorrect of `Style/StringConcatenation` when string includes double quotes.Merge pull request #8824 from koic/fix_an_error_for_layout_class_lengthMerge pull request #8504 from dmytro-savochkin/fix/8354[Fix #8354] Fix Style/CaseLikeIf to handle regexp named capturesDocument interaction of `Style/AccessorGrouping` and `Sorbet` [doc]Fix cop name in Changelog [doc] [ci skip]Merge pull request #8826 from ghiculescu/explicit_block_argument-crashFix crash in Style/ExplicitBlockArgumentMerge pull request #8817 from rdunlop/correct_all_occurrences_of_method_def_parenthesesFix an error for `Metrics/ClassLength`[Fix #8514] Correct multiple Style/MethodDefParentheses per file.Handle comments and blank interpolations in regexp parsed_tree (#8803)Merge pull request #8800 from rdunlop/correct_all_occurrences_of_space_inside_block_braces[Fix #8799] Fix SpaceInsideBlockBraces cop regression.[Fix #8646] Optimize finding target files further (#8815)Tweak several changelog entriesMerge pull request #8802 from rdunlop/correct_all_occurrences_of_space_around_equals_in_parameter_default[Fix #8801] Fix Layouts/SpaceAroundEqualsInParameterDefaultMerge pull request #8809 from pbernays/fix-style-forFix multiple offense detection for Style/ForMerge pull request #8810 from pbernays/fix-style-raise-args[Fix #8759] Fix multiple offense detection for Style/RaiseArgsMerge pull request #8122 from tejasbubane/fix-8102[Fix #8102] Consider class-length instead of block-length for Struct.new[Fix #8646] Optimize the process of finding of all files on RuboCop startup (#8806)Add new `Lint/HashCompareByIdentity` copDocument syntax for multiple cops named in a command-flag[Fix #5713] Explicitly test, and add documentation note, for behaviour of multiline comment blocks (#8798)Switch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands