joenas / huginn_github_notifications_agent

Huginn agent to fetch Github notifications
MIT License
5 stars 1 forks source link

Upgrade rubocop to version 1.0.0 #33

Closed depfu[bot] closed 3 years ago

depfu[bot] commented 3 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.83.0 → ~> 1.0.0) · Repo · Changelog

Release Notes

1.0.0

The first stable RuboCop release ever is finally here! You can read more about this special release here.

New features

  • #7944: Add MaxUnannotatedPlaceholdersAllowed option to Style/FormatStringToken cop. (@Tietew)
  • #8379: Handle redundant parentheses around an interpolated expression for Style/RedundantParentheses cop. (@fatkodima)

Bug fixes

  • #8892: Fix an error for Style/StringConcatenation when correcting nested concatenable parts. (@fatkodima)
  • #8781: Fix handling of comments in Style/SafeNavigation autocorrection. (@dvandersluis)
  • #8907: Fix an incorrect auto-correct for Layout/ClassStructure when heredoc constant is defined after public method. (@koic)
  • #8889: Cops can use new after_<type> callbacks (only for nodes that may have children nodes, like :send and unlike :sym). (@marcandre)
  • #8906: Fix a false positive for Layout/SpaceAroundOperators when upward alignment. (@koic)
  • #8585: Fix false positive in Style/RedundantSelf cop with nested self access. (@marcotc)

Changes

  • #8882: (Potentially breaking) RuboCop assumes that Cop classes do not define new on_<type> methods at runtime (e.g. via extend in initialize). (@marcandre)
  • #7966: (Breaking) Enable all pending cops for RuboCop 1.0. (@koic)
  • #8490: (Breaking) Change logic for cop department name computation. Cops inside deep namespaces (5 or more levels deep) now belong to departments with names that are calculated by joining module names starting from the third one with slashes as separators. For example, cop Rubocop::Cop::Foo::Bar::Baz now belongs to Foo/Bar department (previously it was Bar). (@dsavochkin)
  • #8692: Default changed to disallow Layout/TrailingWhitespace in heredoc. (@marcandre)
  • #8894: Make Security/Open aware of URI.open. (@koic)
  • #8901: Fix false positive for Naming/BinaryOperatorParameterName when defining =~. (@zajn)
  • #8908: Show extension cop versions when using --verbose-version option. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 36 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 3 years ago

Closed in favor of #34.