#9363: Add new cop Lint/OrAssignmentToConstant. (@uplus)
#9326: Add new Lint/NumberedParameterAssignment cop. (@koic)
Bug fixes
#9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. (@koic)
#9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. (@koic)
#9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. (@dvandersluis)
#9387: Fix incorrect auto-correct for Style/NilComparison when using !x.nil? and EnforcedStyle: comparison. (@koic)
#9411: Fix false negatives for Style/EvalWithLocation for Kernel.eval and when given improper arguments. (@dvandersluis)
#7766: Fix Naming/RescuedExceptionsVariableName autocorrection when the rescue body returns the exception variable. (@asterite)
#7766: Fix Naming/RescuedExceptionsVariableName autocorrection to not change variables if the exception variable has been reassigned. (@dvandersluis)
#9389: Fix an infinite loop error for IncludeSemanticChanges: false of Style/NonNilCheck with EnforcedStyle: comparison of Style/NilComparison. (@koic)
#9384: Fix a suggestion message when not auto-correctable. (@koic)
#9424: Fix an incorrect auto-correct for Style/ClassMethodsDefinitions when defining class methods with class << self and there is no blank line between method definition and attribute accessor. (@koic)
#9370: Fix an incorrect auto-correct for Style/SoleNestedConditional when using nested unless modifier multiple conditional. (@koic)
#9406: Fix rubocop_todo link injection when YAML doc start sigil exists. (@dduugg)
#9229: Fix errors being reported with rubocop -V with an invalid config. (@dvandersluis)
#9425: Fix error in Layout/ClassStructure when initializer comes after private attribute macro. (@tejasbubane)
Changes
#9415: Change Layout/ClassStructure to detect inline modifiers. (@AndreiEres)
#9380: Mark Style/FloatDivision as unsafe. (@koic)
#9345: Make Style/AsciiComments allow copyright notice by default. (@koic)
#9399: Added AllowedCops configuration to Style/DisableCopsWithinSourceCodeDirective. (@dvandersluis)
#9327: Change Layout/EmptyLineAfterMagicComment to accept top-level shareable_constant_values directive. (@tejasbubane)
#7902: Change Lint/NumberConversion to detect symbol form of conversion methods. (@tejasbubane)
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.
All Depfu comment commands
@depfu rebase
Rebases against your default branch and redoes this update
@depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@depfu close
Closes this PR and deletes the branch
@depfu reopen
Restores the branch and reopens this PR (if it's closed)
@depfu pause
Ignores all future updates for this dependency and closes this PR
@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot]
commented
3 years ago
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.83.0 → ~> 1.9.0) · Repo · Changelog
Release Notes
1.9.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 60 commits:
Cut 1.9.0Update ChangelogFix an incorrect auto-correct for `Style/ClassMethodsDefinitions`Add new `InternalAffairs/RedundantLetRuboCopConfigNew` copMerge pull request #9426 from tejasbubane/fix-9425[Fix #9425] Fix error in `Layout/ClassStructure` when initializer comes after private attribute macroFix false negatives for `Style/EvalWithLocation` for `Kernel.eval` and when given improper arguments.[Fix #9415] Change `Layout/ClassStructure` to detect inline modifiersFix `InternalAffairs/ExampleDescription` offenses.Add new `InternalAffairs/ExampleDescription` cop.Add new `InternalAffairs/RedundantDescribedClassAsSubject` copMerge pull request #9422 from koic/tweak_new_cop_templateTweak new cop template[Fix #7902] Change `Link/NumberConversion` to detect symbol form of conversion methodsMerge pull request #9418 from dvandersluis/trailing-empty-lines-specsFix `Layout/TrailingEmptyLines` spec to not need to use `raise_error`.Add new `Style/IfWithBooleanLiteralBranches` cop[Fixes #9340] Added `info` Severity level to allow offenses to be listed but not return a non-zero error code.Add new `Lint/TripleQuotes` cop.[Fix #9327] Change `Layout/EmptyLineAfterMagicComment` to accept top-level `shareable_constant_values` directive[Fixes #9399] Added `AllowedCops` configuration to `Style/DisableCopsWithinSourceCodeDirective`.Add new `InternalAffairs/EmptyLineBetweenExpectOffenseAndCorrection` copFix a typo for `Style/SingleLineMethods`Merge pull request #9409 from dvandersluis/eval-with-locationMerge pull request #9406 from dduugg/fix-insert-bugTweak offense messages for `Style/NonNilCheck` copImprove messages and documentation for `Style/EvalWithLocation`.Merge pull request #9400 from dvandersluis/issue/7766Fix rubocop_todo link injection when YAML doc start sigil exists[Fixes #7766] Fix `Naming/RescuedExceptionsVariableName` autocorrection issues.Improve project_spec tests when expected configuration for a cop is missing.Add changelog entry for `Lint/LambdaWithoutLiteralBlock` copFix autocorrection of trivial body for `Naming/RescuedExceptionsVariableName` (#9398)Merge pull request #9382 from dvandersluis/issue/9374Merge pull request #9390 from koic/fix_infinite_loop_error_for_non_nil_checkFix an infinite loop error for `Style/NonNilCheck` with `Style/NilComparison`[Fix #9374] Don't autocorrect `Layout/LineLength` for a method where the first argument is a hash, if it will result in a syntax error.Workaround for JRuby 9.2.14.0[Fix #9345] Make `Style/AsciiComments` allow copyright notice[Fix #9387] Fix incorrect auto-correct for `Style/NilComparison`Fix a suggestion message when not auto-correctable[Fixes #7827] Add pre-commit hookMark `VersionChanged: <<next>>` for `Style/FloatDivision`[Fix #7452] Support `IgnoredMethods` option for `Style/FormatStringToken`[Fix #9380] Mark `Style/FloatDivision` as unsafeMerge pull request #9363 from uplus/add-new-cop-or_assignment_to_constantMerge pull request #9375 from koic/fix_error_for_style_if_inside_elseMerge pull request #9371 from koic/fix_an_incorrect_autocorrect_for_style_sole_nested_conditionalAdd new cop `Lint/OrAssignmentToConstant`[Fix #9372] Fix an error for `Style/IfInsideElse`[Fix #9370] Fix an incorrect auto-correct for `Style/SoleNestedConditional`Fix typo for AllowedIdentifiers example[Fix #9366] Fix an incorrect auto-correct for `Style/SoleNestedConditional`Fix errors being reported with `rubocop -V` with an invalid config.Change ConfigLoader#added_features to be a Set.Allow a `Config` object to be created without running validations.Add new `Lint/NumberedParameterAssignment` copCorrect `Lint/SymbolConversion` offenses.[Fix #9353] Add new `Lint/SymbolConversion` cop.Switch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands