#4182: Add Lint/AmbiguousRange cop to check for ranges with ambiguous boundaries. (@dvandersluis)
#10000: Parallel static analysis by default. (@koic)
#9948: Support Ruby 2.7's pattern matching for Style/ConditionalAssignment cop. (@koic)
#9999: Add new Style/RedundantSelfAssignmentBranch cop. (@koic)
Bug fixes
#9927: Indent hash values in Layout/LineEndStringConcatenationIndentation. (@jonas054)
#9959: Make Style/IdenticalConditionalBranches able to handle ternary ifs. (@dvandersluis)
#9946: Avoid slow regexp matches in Style/CommentedKeyword. (@jonas054)
#7422: Treat constant assignment like other assignment in Layout/SpaceAroundOperators. (@dvandersluis)
#9953: Fix an infinite loop error and a false auto-correction behavior for Layout/EndAlignment when using a conditional statement in a method argument. (@koic)
#9958: Prevent an infinite loop when a detected method has fewer arguments than expected. (@dvandersluis)
#9977: Update Layout/EmptyLineAfterGuardClause to not register an offense if there is another expression following the guard clause on the same line. (@dvandersluis)
#9980: Fix a false positive for Style/IdenticalConditionalBranches when assigning to a variable used in a condition. (@koic)
#9975: Parentheses are always required for Style/MethodDefParentheses when a forwarding argument (...) is used. (@dvandersluis)
#9984: Fix false negatives involving heredocs for Layout/SpaceBeforeComma, Layout/SpaceBeforeComment, Layout/SpaceBeforeSemicolon and Layout/SpaceInsideParens. (@dvandersluis)
#9954: Fix infinite loop error for Layout/HashAlignment when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. (@koic)
#10002: Fix an incorrect auto-correct for Lint/AmbigousRegexpLiteral when using nested method arguments without parentheses. (@koic)
#9952rubocop-rspec#1126: Fix inherit_mode for deeply nested configuration defined in extensions' default configuration. (@pirj)
#9957: Add WholeWord configuration to Naming/InclusiveLanguage's FlaggedTerms config. (@dvandersluis)
#9970: Don't register an offense when sort method has arguments for Style/RedundantSort cop. (@mtsmfm)
#4097: Add require English for special globals. (@biinari)
#9955: Fix Style/ExplicitBlockArgument adding a second set of parentheses. (@dvandersluis)
#9973: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue keyword and leading dot. (@koic)
#9945: Fix auto-correction of lines in heredocs with only spaces in Layout/TrailingWhitespace. (@jonas054)
Changes
#9989: Mark Style/CommentedKeyword as unsafe auto-correction. (@koic)
#9964: Make Layout/LeadingCommentSpace aware of #:nodoc. (@koic)
#9985: Mark Style/IdenticalConditionalBranches as unsafe auto-correction. (@koic)
#9962: Update Style/WordArray to register an offense in percent style if any values contain spaces. (@dvandersluis)
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.
All Depfu comment commands
@depfu rebase
Rebases against your default branch and redoes this update
@depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@depfu close
Closes this PR and deletes the branch
@depfu reopen
Restores the branch and reopens this PR (if it's closed)
@depfu pause
Ignores all future updates for this dependency and closes this PR
@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot]
commented
3 years ago
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.83.0 → ~> 1.19.0) · Repo · Changelog
Release Notes
1.19.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 61 commits:
Cut 1.19.0Update Changelog[Fix #9980] Fix a false positive for `Style/IdenticalConditionalBranches`[Fix #9962] Update `Style/WordArray` to register an offense in `percent` style if any values contain spaces.[Fix #9973] Fix a false positive for `Layout/RescueEnsureAlignment`[Fix #4182] Add `Lint/AmbiguousRange` cop to check for ranges with ambiguous boundaries.Add new `Style/RedundantSelfAssignmentBranch` copAdd doc and test for about pattern matching for `Style/MissingElse`Update `StyleGuide` URL for `Style/WhenThen`Update the doc for `Style/BlockDelimiters`[Fix #9989] Mark unsafe auto-correct for `Style/CommentedKeyword`Use parallel static analysis by default (#10000)Merge pull request #10003 from koic/fix_incorrect_autocorrect_for_lint_ambiguous_regexp_literalMerge pull request #9994 from dvandersluis/issue/5022[Fix #10002] Fix an incorrect auto-correct for `Lint/AmbigousRegexpLiteral`Merge pull request #10001 from dvandersluis/issue/7422[Fix #7422] Treat `casgn` nodes like other assignment nodes in `Layout/SpaceAroundOperators`.[Fix #5022] Fix false negative for `Lint/DuplicateMethods` inside `class << self`.Merge pull request #9987 from dvandersluis/internal/undefined-configMerge pull request #9995 from dvandersluis/duplicate-methods-testsTemporarily mark some `Lint/DuplictaeMethods` specs as pending in order to be able to cleanly merge rubocop/rubocop-ast#197.Merge pull request #9988 from jonas054/9927_LineEndStringConcatenationIndentation_indented_hash_values[Fix #9927] Indent hash values in LineEndStringConcatenationIndentationMerge pull request #9985 from koic/mark_unsafe_autocorrect_for_style_identical_conditional_branchesFix `InternalAffairs/UndefinedConfig` offenses.Add `InternalAffairs/UndefinedConfig` cop to highlight configuration keys that are used in cops but not defined in `config/default.yml`.Merge pull request #9984 from dvandersluis/heredoc-spacingUpdate `Layout/SpaceBeforeComment` to handle heredocs.Update `Layout/SpaceBeforeComma` and `Layout/SpaceBeforeSemicolon` to handle heredocs.Update `Layout/SpaceInsideParens` to handle heredoc method arguments.Mark `Style/IdenticalConditionalBranches` as unsafe auto-correction[Fix #9977] Update `Layout/EmptyLineAfterGuardClause` to not register an offense if there is another expression following the guard clause on the same line.Fix typo `accpets` -> `accepts` in specs.Merge pull request #9970 from mtsmfm/sort-with-arg[Fix #9957] Add `WholeWord` configuration to `Naming/InclusiveLanguage`'s `FlaggedTerms` config.Enable basic autocorrection for `Style/Semicolon`.Minor refactoring of `Style/Semicolon`, allow it to find multiple offenses on one line.Remove unnecessary code for unsupported Ruby 2.4Merge pull request #9976 from dvandersluis/issue/9975[Fix #9975] Parentheses are always required when a forwarding argument (`...`) is used.Fix `inherit_mode` for arrays in extension default[Fix #9953] Fix a false auto-correction behavior for `Layout/EndAlignment`[Fix #9954] Fix an infinite loop error for `Layout/HashAlignment`[Fix #4097] Add require English for special globalsMake `Layout/LeadingCommentSpace` aware of `#:nodoc`[Fix #9955] Fix `Style/ExplicitBlockArgument` adding a second set of parentheses.[Fix #9959] Make `Style/IdenticalConditionalBranches` able to handle ternary `if`s.[Fix #9958] Prevent an infinite loop when a detected method has fewer arguments than expected.Merge pull request #9969 from koic/add_internal_affairs_inherit_deprecated_cop_class_copDon't register an offense when sort method has arguments for `Style/RedundantSort` copMerge pull request #9972 from deivid-rodriguez/fix_windows_ciTry fix CI errors on WindowsAdd `InternalAffairs/InheritDeprecatedCopClass` copMerge pull request #9971 from koic/workaround_for_bundler_2_2_5_on_windowsWorkaround for CI build error when using Bundler 2.2.5 on WindowsSupport Ruby 2.7's pattern matching for `Style/ConditionalAssignment`Merge pull request #9950 from jonas054/9945_fix_TrailingWhitespaceMerge pull request #9949 from jonas054/9946_fix_hanging_CommentedKeywordSwitch back the docs version[Fix #9945] Fix heredoc indentation in trailing space corrections[Fix #9946] Avoid slow regexp match in Style/CommentedKeywordDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands