joenzkc / pe

0 stars 0 forks source link

Reminder reminds after 10 seconds of every new command, not just reminder updated for a friend #4

Open joenzkc opened 2 years ago

joenzkc commented 2 years ago

In the UG, it is stated:

image.png

What I assume this means is that upon updating the notification status of any person (i.e. switching on a reminder or switching off a reminder), it will give me a reminder in 10 seconds after that.

However, what I notice is that after ANY command, such as adding a new person in who's birthday is not today, or editing another persons birthday, it will also trigger the reminder

Steps to reproduce:

  1. Input add n/Johnathan Doenut e/lol@gmail.com p/123123123 b/2021-11-12 r/on
  2. After 10 seconds, reminder pops up wishing him happy birthday, this is expected
  3. Input edit 10 n/editsomeoneelse (where 10 is the index of someone who is not Johnathan Doenut)
  4. Even though I am not editing any persons reminder updated (which i presume is r/on or off), after 10 seconds, the reminder will pop up for Johnathan Doenut

This can be quite annoying for users as the pop up will keep popping up after every command after 10 seconds, which would possibly cause me to disable to notification, and forget about it next year, which defeats its purpose.

nus-pe-bot commented 2 years ago

Team's Response

every Commands makes an update to the list.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

sends reminder after every addition of a new friend

i felt that this is actually quite annoying and when the reminder window is up, we cannot actually ignore it and just continue using the application, the window must be closed before we can continue using, probably should just remind once when we start up the application image.png


[original: nus-cs2103-AY2122S1/pe-interim#5573] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Under the UG and DG, was already mentioned on the behavior of the reminder. Though improvements can be made, tester being annoyed doesn't give a clear picture of the issue he/she is sharing.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: In my bug report (not the original issue), I clearly show a screenshot from the UG which states that The reminder interval resets with any reminder updated for a friend. I clearly replicate the bug by showing that while I am updating a field of a Person which is not related to the reminder (i.e. the name of the person), the reminder still pops up after 10 seconds. I don't think the issue is unclear and the response "every Command makes an update to the list" does not explain anything. Perhaps "every command UPDATES THE REMINDER for a friend" will make more sense, but I still believe that this would be implicitly implied and there is no way for the user to know from reading the UG, hence I chose Medium severity as it does affect usage and does not reflect what is stated in the UG.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This will cause occasional inconvenience (i.e. every 10 seconds of a new command!) to users and they can still continue to use the product, which is severity.medium