joepool / homebridge-sky-q-no-logs

Homebridge plugin to control a Sky Q box with reduced logging.
https://www.npmjs.com/package/homebridge-sky-q-no-logs
MIT License
4 stars 0 forks source link

Error in logs - V1.1.3 #1

Open marksthomas opened 3 years ago

marksthomas commented 3 years ago

Hi

Getting the following alert in my Homebridge logs.

'The plugin 'homebridge-sky-q-no-logs' slows down requests made to homebridge! The read handler for the characteristic 'On' didn't respond at all!. Please check that you properly call the callback!'

V1.1.3 of the plug-in V1.3.0-Beta.49 of Homebridge (but same error occurs in latest stable build).

"accessories": [
    {
        "name": "Sky",
        "ipAddress": "192.168.86.21",
        "accessory": "SkyQ"
    }
],
marksthomas commented 3 years ago

Anything on this? Still getting the error.

joepool commented 3 years ago

Sorry about this, for some reason I didn't get a email when you opened this issue like I normally do. I'll have a look in the next couple of days and try to fix this.

marksthomas commented 3 years ago

No worries :) thanks man.

joepool commented 3 years ago

I have just published a beta version 1.3.0-beta.0 which hopefully will fix this error, at least it has for me.
Please update to the beta and let me know if the error is fixed, if it is I will publish it fully.

Thanks!

marksthomas commented 3 years ago

Just done it. I’ll report back in the morning!

thanks for this!

marksthomas commented 3 years ago

Looks good. No errors overnight!

good work.

joepool commented 3 years ago

Awesome, thanks for testing!
I'll make sure everything is working and no more errors appear, then publish the public version soon.

joepool commented 3 years ago

Reopening this issue, I seem to have missed an error that causes home bridge as a whole to crash if a Sky Q box is controlled from an automation.
Don't know how I missed that in testing. Hopefully I can work out a fix, if not I'll republish v1.1.3 as the latest version and work it out properly. Its always so much fun trying to debug someone else's code!

marksthomas commented 3 years ago

Oops! Was about to create an automation too so good catch :) - hang fire on that for a mo then lol :)

joepool commented 3 years ago

This should be fully fixed in version 1.3.1 which I have just published.

marksthomas commented 3 years ago

Nice one!

joepool commented 3 years ago

Another characteristic warning in my logs this morning.
[3/5/2021, 5:47:02 AM] [homebridge-sky-q-no-logs] This plugin slows down Homebridge. The read handler for the characteristic 'On' was slow to respond! See https://git.io/JtMGR for more info. I guess its not fixed then. Ill try my best in the next couple of days to fix this.

marksthomas commented 3 years ago

Ah, yeah, same here. Weird it came back. No worries, thanks :)

samwhu30 commented 2 years ago

I am having this same issue.