Add 'dd' keybinding for SQHDatabase

jbyte commented 6 years ago

Added enhancement for issue #10 . Functionality:

function mysql#DropDatabase(database, show)
command SQHDropDatabase calls mysql#DropDatabase, gets database argument from command line and show is set to 0 (so it doesnt open new buffer with database list)
key mapping 'dd' for mysql#DropDatabase function, gets database argument from cursor and show is set to 1 (closes current SQHDatabase buffer and open a new updated one)

joereynolds commented 6 years ago

Nice work!

I have 2 small requests.

1) Create a global config option (I was thinking g:i_like_to_live_life_dangerously heh...) This should be set to 0 by default. When a user has this set to 0, any destructive operation (such as dropping tables and databases) will prompt the user beforehand with something along the lines of "Confirm deleteion of your_database_name? "

This is very dangerous stuff so default behaviour should definitely protect the idiots (i.e. me) from deleting and destroying everything.

2) Can you add your new commands etc... to the docs if they're missing?

Thanks for the PR!

jbyte commented 6 years ago

Hello!

Oops forgot about the docs, will add them and the global config option when I get home.

Thanks for the fast reply!

jbyte commented 6 years ago

I think it all should be good now.

joereynolds commented 6 years ago

Congrats on the PR! :D

joereynolds / SQHell.vim

Add 'dd' keybinding for SQHDatabase #21