Add 'dd' keybinding for SQHTable buffer

joereynolds / SQHell.vim

An SQL wrapper for vim

MIT License

131 stars 9 forks source link

Closed jbyte closed 6 years ago

jbyte commented 6 years ago

Implemented the enhancement from issue #9.

Functionality:

function mysql#DropTableFromDatabase(database, table, show)
function mysql#DropTableSQHTableBuf(table, show), calls mysql#DropTableFromDatabase while getting database from opened SQHTable buffer
command SQHDropTableFromDatabase calls mysql#DropTableFromDatabase, gets database and table arguments from command line and show is set to 0 (so it does not open a SQHTable buffer)
key mapping 'dd' for mysql#DropTableSQHTableBuf function, gets database from mysql#GetDatabaseName, table from cursor, and show is set to 1 (reloads the current SQHTable buffer)

joereynolds commented 6 years ago

Looks good,

one small thing

Can you change this and your previous pr's command to take the g:sqh_provider in the command.

So basically update this:

command! -nargs=1 SQHDropDatabase :call mysql#DropDatabase(<q-args>, 0)

To this command! -nargs=1 SQHDropDatabase execute ":call " . g:sqh_provider . "#DropDatabase(<q-args>, 0)"

jbyte commented 6 years ago

Sure, no problem I'll be right on it.

joereynolds commented 6 years ago

Thanks and good job!