search

joereynolds / SQHell.vim

An SQL wrapper for vim
MIT License
131 stars 9 forks source link

SQHExecuteLine and SQHExecuteBlock without range does the same #31

Closed hauleth closed 6 years ago

hauleth commented 6 years ago

There is no need for SQHExecuteBlock and separate SQHExecuteLine as documentation states that:

    -range      Range allowed, default is current line

I would replace them with one command SQHExecute.

joereynolds commented 6 years ago

Agreed, consider it on the list

hauleth commented 6 years ago

Overall public API could be reduced I think. SHQExecute would execute current line or selection SQHExecute! would execute current file or given file.

joereynolds commented 6 years ago

Again, I agree. The public API definitely needs some slimming down.

The less code the better!

joereynolds commented 6 years ago

How's this?

https://github.com/joereynolds/SQHell.vim/commit/8e63fe7147c0b408ec8c126ef2c0b0514cc66087

Nothing like learning as you go ey? ha