MySQL provider doesn't work with an empty password

joereynolds / SQHell.vim

An SQL wrapper for vim

MIT License

131 stars 9 forks source link

MySQL provider doesn't work with an empty password #48

Open tofulm opened 6 years ago

tofulm commented 6 years ago

Hello, My default config of mysql has an empty password.

the prompt ask the password but it's not possible to write it down.

With Neovim 2.3

joereynolds commented 6 years ago

Hey,

Thanks for the report! I'll take a look

joereynolds commented 6 years ago

[ ] Allow command to work with and without password
[ ] Fix postBufferFormat behaviour
[ ] Fix 'e' on SQHResult buffer
[x] Refactor getDatabaseName
[ ] Tests that check mysql works with and without a password (if one is not set)
[x] Tests that check for Tablesin anywhere in the buffer, not necessarily the first line
[x] Tests for postBufferFormat (buffers that show the password warnings, buffers with just a newline, and a normal buffer)

deeuu commented 5 years ago

Hey, I also ran into this issue (empty password doesn't work with MYSQL provider).

I think the fix is as easy replacing this with:

let l:password = '--password=' . a:password . ' '

I can send a PR, but I'm not sure about the items checked in your comment?

joereynolds commented 5 years ago

Hey @deeuu,

You're welcome to raise a PR, don't worry about the items in my comment, those are ongoing, though if you can add some tests around the area that'd be great :D

Thanks :)