joergbrech / moxunit-action

A Github action for Matlab or Octave unit tests

MIT License

14 stars 7 forks source link

fix test keyword in README example #15

Closed jorgepz closed 3 years ago

jorgepz commented 3 years ago

Since the version was changed, the test keyword has to be changed.

codecov-io commented 3 years ago

Codecov Report

Merging #15 (4fa60f8) into master (4e74a5c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            7         7           
=========================================
  Hits             7         7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e74a5c...4fa60f8. Read the comment docs.

joergbrech commented 3 years ago

Actually the tests keyword is fine: By writing uses joergbrech/moxunit-action@v1 you specify that you want to use the latest v1.x.x version, see https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsuses. Currently, that would be 1.1.

For version 1.1 and higher the keyword is tests and not test_directory

BTW, that's why I wanted tge version specifier to be changed in #14.

jorgepz commented 3 years ago

Thanks for the explanation! I thought that was not right, since I got this warning

Warning: Unexpected input(s) 'tests', valid inputs are ['entryPoint', 'args', 'test_directory', 'src_directory']

running the v1 at a test repo https://github.com/jorgepz/Octave-Matlab-CI-testbed/runs/1896852522?check_suite_focus=true Maybe I am doing something wrong. Thanks in advance!

joergbrech commented 3 years ago

Ah, good to know! Thanks for testing. I always assumed github actions did this automatically, but apparently I have to manage the major release tags myself: https://github.com/marketplace/actions/update-major-version, https://github.com/marketplace/actions/update-major-version

I will take care of it in the next couple of days. Still, I would prefer to only reference the major version in the README for now.

jorgepz commented 3 years ago

Great! I guess that after fixing that the warning will be silenced, so I will close this PR.