Installation Issues - Githubissues

akaszynski commented 3 years ago

Hello,

I'm reviewing your submission for JOSS and having a tough time getting started installing your library. I'd suggest the following:

Provide a package of your library on PyPi
Check for an installation of OGS and then raise a descriptive error when the application is missing. For example, immediately after: https://github.com/joergbuchwald/ogs6py/blob/354945b8499fa30829013648f03946d5d9e89bc1/ogs6py/ogs.py#L114-L117 Add a test if the file exists with os.path.isfile, and then point the user to a url containing application installation directions.
Avoid non-descriptive runtime errors: https://github.com/joergbuchwald/ogs6py/blob/354945b8499fa30829013648f03946d5d9e89bc1/ogs6py/ogs.py#L139

Cheers! Alex

leouieda commented 3 years ago

Related to openjournals/joss-reviews#3673 (so we can see the status in the review issue)

joergbuchwald commented 3 years ago

Hi @akaszynski, thanks for reviewing. Concerning the first point, ogs6py is already on PyPI: https://pypi.org/project/ogs6py/ Perhaps, I should add that to the installation instructions as well...

akaszynski commented 3 years ago

thanks for reviewing. Concerning the first point, ogs6py is already on PyPI: https://pypi.org/project/ogs6py/ Perhaps, I should add that to the installation instructions as well...

Ha! I feel stupid for not even looking. Yes, directions would be helpful for that.

joergbuchwald / ogs6py

Installation Issues #14