Closed cpgr closed 3 years ago
somewhere that this requires python >= 3.8
Ideally you can also set the python_requires
argument in setup.py
but it's always good to state in the docs somewhere as well.
Thanks for the suggestions, I added a note to the readme concerning the python version as well as how to run the unittests and also enforced the python version 3.8 in setup.py
.
Overall I think this is a pretty good tool for the OGS community, so well done.
I have some minor suggestions:
tests\test_ogs6py.py
from within thetests
directory and got a load of missing file errors. It obviously has to be run from the mainos6py
directory (all the tests passed when I ran it there 😄).:=
don't work in versions < 3.8).Refs openjournals/joss-reviews#3673