joergbuchwald / ogs6py

Python-API for the OpenGeoSys (http://www.opengeosys.org) software.
BSD 3-Clause "New" or "Revised" License
16 stars 23 forks source link

Suggestions from JOSS review #17

Closed cpgr closed 3 years ago

cpgr commented 3 years ago

Overall I think this is a pretty good tool for the OGS community, so well done.

I have some minor suggestions:

Refs openjournals/joss-reviews#3673

leouieda commented 3 years ago

somewhere that this requires python >= 3.8

Ideally you can also set the python_requires argument in setup.py but it's always good to state in the docs somewhere as well.

joergbuchwald commented 3 years ago

Thanks for the suggestions, I added a note to the readme concerning the python version as well as how to run the unittests and also enforced the python version 3.8 in setup.py.